1712632 - Tags (fields) in Quick Filter bar are not displayed properly in Dark Theme

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Slobodan]

Attachment: TB.PNG

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:88.0) Gecko/20100101 Firefox/88.0

Steps to reproduce:

I switched from "Light/Default" theme to "Dark" theme.
As an example, in attached picture, "Unread" tag is selected, "Starred" tag is deselected, but they look the same.

Actual results:

It can't be seen if any of the tags in the Quick Filer bar is selected.
This tags are: "Pin symbol", "Unread", "Starred", "Contact", "Tags", "Attachment", "Sender", "Recipients", "Subject" and "Body".

Expected results:

It should be visible if any of these tags is selected (clicked). Selected tags should have different background from those that are note selected.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1712632-win7-QFB-styling.patch

There are styles that are no more needed.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9223394 [details] [diff] [review]
1712632-win7-QFB-styling.patch

Review of attachment 9223394 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.

This doesn't need to (and actually can't) land on trunk as it's 78 specific.

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 9223394 [details] [diff] [review]
1712632-win7-QFB-styling.patch

[Approval Request Comment]
User impact if declined: On Windows 7 and dark theme not visible checked state of the QFB buttons.
Testing completed (on c-c, etc.): TB 78 only
Risk to taking this patch (and alternatives if risky): low

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9223394 [details] [diff] [review]
1712632-win7-QFB-styling.patch

[Triage Comment]
Approved for esr78

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 78.11.0:
https://hg.mozilla.org/releases/comm-esr78/rev/2fe9cdb3548f