1712739 - Migrate ConsoleCommand.evaluateJSAsync and WebConsoleFront.evaluateJSAsync to a command

Status: RESOLVED FIXED

(DevTools :: Console, task)

Description

[Alexandre Poirot [:ochameau]]

ConsoleCommands should be replaced by a generic command, hosted in devtools/shared/commands.
https://searchfox.org/mozilla-central/source/devtools/client/webconsole/commands.js#17
This would make it easier to use from any place in DevTools frontend and avoid having this console-specific ConsoleCommands module.

While we are at it, we can probably merge it with the front's evaluateJSAsync method:
https://searchfox.org/mozilla-central/source/devtools/client/fronts/webconsole.js#99
and so also move WebConsoleFront.evaluateJSAsync to the command, so that the front is no longer having any custom implementation for this method.
(Long term, fronts should no longer have any custom class)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1712739 - [devtools] Add a `script` command with an `execute` method. r=jdescottes.

This method is meant to replace the direct usage
of webconsoleFront.evaluateJSAsync.
The WebConsoleCommands file is removed, and all
client calls to evaluateJSAsync are migrated to
the new method. Callsites are simplified when
possible, and some test are refactored to switch
to spawned task to retrieve content page information.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1712739 - [devtools] Fold custom WebConsoleFront#evaluateJSAsync method into scriptCommand#execute. r=ochameau.

Depends on D116242

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac9ae179ece1
[devtools] Add a `script` command with an `execute` method. r=jdescottes.
https://hg.mozilla.org/integration/autoland/rev/a130967c1393
[devtools] Fold custom WebConsoleFront#evaluateJSAsync method into scriptCommand#execute. r=ochameau.

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/ac9ae179ece1
https://hg.mozilla.org/mozilla-central/rev/a130967c1393