Closed Bug 1712847 Opened 7 months ago Closed 6 months ago

No space / padding between subviewbutton nav arrow on connection security item in identity panel

Categories

(Firefox :: Site Identity, defect)

Desktop
Windows 10
defect

Tracking

()

VERIFIED FIXED
90 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox88 --- unaffected
firefox89 --- unaffected
firefox90 --- verified

People

(Reporter: Gijs, Assigned: emmamalysz)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [proton-door-hangers] [proton-cleanups])

Attachments

(4 files)

Attached image image.png

There appears to be no space between the arrow and the edge of the hover state. I assume this is not intentional. I ran mozregression and this appears to have changed in bug 1706379 - Emma, can you confirm this wasn't intentional?

Flags: needinfo?(emalysz)
Attached image Previous state

This is what it looked like before.

Severity: -- → S4

Not intentional!

Though I can't reproduce image #1 on Mac. I still see the "previous state" image. Either way, the padding should probably match other subview buttons in tree. I attached one for reference

Assignee: nobody → emalysz
Status: NEW → ASSIGNED
Flags: needinfo?(emalysz)
Attached image Subview padding

(In reply to Emma Malysz from comment #2)

Though I can't reproduce image #1 on Mac. I still see the "previous state" image.

Sorry, I mistakenly filed this as desktop/all - I noticed it on Windows. I've updated the bug.

OS: All → Windows 10
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/295f5c5c4dd6
increase spacing for end chevron in site identity panel r=desktop-theme-reviewers,harry
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

I've reproduced this issue on Win 10 x64, using an affected Nightly build from 2021-05-25.

The issue is verified as fixed on latest Beta 90.0b11 running Win 10 x64.

Status: RESOLVED → VERIFIED
Duplicate of this bug: 1709114
You need to log in before you can comment on or make changes to this bug.