1706379 - (Proton) (regression) Site identity panel animation is no longer smooth

Status: RESOLVED FIXED

(Firefox :: Site Identity, defect, P2)

Description

[Sören Hentzschel]

Attachment: screencast

Since the landing of the new identity panel style the animation when navigating from the subpanel back to the main panel is no longer smooth, the footer row for deleting cookies and website data jumps. Please see the attached video.

Comment 1

[Release mgmt bot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1703012

Comment 2

[Romain Testard [:RT]]

Is this a dupe of 1692519?

Comment 3

[Mike Conley (:mconley) (:⚙️)]

I don't think so... it looks less like a graphics glitch, and more like we're applying some kind of CSS rule after the animation completes rather than before. So I think this is separate.

Comment 4

[Ciprian Georgiu [:ciprian_georgiu], Release Desktop QA]

I ran mozregresssin in order to find out what broke this, and it seems that one of the patches from this pushlog is the culprit. Emma, would you mind taking a look at this?

changeset: ac952451dc017a284361b54e1390b29e4cb8f3fa
pushlog_url: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ac952451dc017a284361b54e1390b29e4cb8f3fa&tochange=14f7b86bc41ad55974a1b10a21c93d1cdb9d12e4

Comment 5

[Emma Malysz]

It looks like these 2 css rules are causing issues:
https://searchfox.org/mozilla-central/rev/71515d047cbdd02687a1b9b7265f2ffb51300bf1/browser/themes/shared/controlcenter/panel.inc.css#504,544-546

I'll look into an alternative

Comment 6

[Emma Malysz]

Attachment: Bug 1706379: improve site identity css rules for smooth animation

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5aef1459fece
improve site identity css rules for smooth animation r=mconley

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/5aef1459fece

Comment 9

[Sören Hentzschel]

The fix does not work at all, at least not on macOS. The behaviour seems to be exactly the same as without the patch.

Comment 10

[Paul Zühlcke [:pbz]]

Emma, could you please take another look? Thanks!

Comment 11

[Emma Malysz]

Attachment: siteIdentityAnimation.mov

Comment 12

[Emma Malysz]

Hi Sören, are you still seeing this issue on the current nightly build? I attached a video of the improved experience I'm seeing on macOS. Note the icon overlap should be addressed in Bug 1709106

This patch is treated as a CSS band-aid to alleviate some of the bumpiness in the transition, so I don't think it perfectly addresses the issue. However, I think we should use Bug 1708819 to fix the root cause of the problem and uplift this, as I think it's an improvement from the first video.

Comment 13

[Sören Hentzschel]

Yes, for me it still looks exactly the same as in the video that was attached in the original report. I can reproduce this on two different devices, both devices have the same configuration.

Device: MacBook Pro Late 2018, 2,6 GHz 6-Core Intel Core i7, 16 GB 2400 MHz DDR4
OS: macOS 11.3
Firefox Build: Nightly build from 2021-05-03.

Comment 14

[Emma Malysz]

Hi Sören, thanks for providing all of this info! We're going to handle the fix for the issue you're still seeing in Bug 1708819 and close out this particular bug. While the patch doesn't address the issue you're encountering, it does seem to improve the experience for other users, so it's a net win for now.

Tyler or Romain, is it safe to uplift this patch? It doesn't look like any regressions have been filed, and it landed a couple of days ago

Comment 15

[Romain Testard [:RT]]

Hi Emma, I'm not clear on what the patch fixes in terms of user experience. The video shows the overlap issue raised on bug 1709106 - is this a regression introduced by the patch?
At this stage we'll only want to uplift icon changes and bugs identified as P1s to avoid introduction of new regressions so this one feels like it should track 90 along with Bug 1708819.

Comment 16

[Tyler Duzan]

Howdy Emma, can you reply to Romain's question above? On initial reading, I thought this may be related to other issues with panel animations, but I'm not actually sure what was fixed in this bug vs what was broken out.

Thanks

Comment 17

[Emma Malysz]

This patch reduced the jerky animation on some devices, so I figured the non-zero impact was worth uplifting. Comparing the two videos, there's less of a jump on the "Clear cookies" footer.

This bug did not introduce the regression we see in bug 1709106, but it looks lie there's a patch up to handle that case. Since there's still a bug associated with the panel animation that will be handled in Bug 1708819, perhaps we're better off letting this ride the trains of release

Comment 18

[Romain Testard [:RT]]

Thanks, marking this bug now as "won't fix" for 89