1712868 - Upgrade onboarding: aria-live should not be set on entire dialog

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P3)

Description

[James Teh [:Jamie]]

STR (with the NVDA screen reader):

1. Ensure Firefox is not your default browser.
2. In about:config, set browser.startup.homepage_override.mstone to 88.0 and browser.startup.upgradeDialog.version to 88. Restart Firefox.
3. On the default browser screen, choose "Not now".
   • Expected: NVDA should say "Get a clean start with an updated theme, Save theme button"
   • Actual: NVDA says "Save theme, Follow the operating system theme for buttons, menus, and windows Use a light theme for buttons, menus, and windows Use a dark theme for buttons, menus, and windows Use a dynamic, colorful theme for buttons, menus, and windows, Not now, Get a clean start with an updated theme, Save theme button"

Reading the text of all the controls in the dialog makes for excessive verbosity, but it's also very confusing for the user because the controls are read without any semantic information. The reason for this is the aria-live="polite" added on the dialog in bug 1705091.

aria-live on the dialog should be removed. Instead, it should be placed on the h1 with id title. This way, the title of the dialog will be read when it changes, but not the entire text of all controls.

Comment 1

[Ed Lee :Mardak]

Attachment: Bug 1712868 - Move aria-live to the title instead of whole upgrade dialog r?emcminn

Comment 2

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1705091

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/deba1ae62f14
Move aria-live to the title instead of whole upgrade dialog r=emcminn

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/deba1ae62f14

Comment 5

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Beta (90.0b1 Build ID - 20210601190019) installed on Windows 10 x64. Now I can confirm that the NVDA screen reader software says "Get a clean start with an updated theme, Save theme button" when the "Theme" upgrade modal is opened.