1712875 - Fix the union of the flex items' margin boxes which we add flex container's padding to

Status: RESOLVED FIXED

(Core :: Layout: Flexbox, defect)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Attachment: Testcase 1

In bug 1697349, we include the flex container's padding by inflating the union of flex items' margin boxes. However, nsIFrame::GetMarginRect() returns the margin rect that is shifted by position: relative, so it probably doesn't make sense to see flex container's padding at the edge of a position: relative flex item.

See Testcase 1. On Google Chrome and Safari, the flex container doesn't have scrollbars. Firefox 88 also has no scrollbars.

Comment 1

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1697349

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Attachment: Bug 1712875 - Inflate flex container's padding by using the union of flex items' normal position margin boxes.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c786a99f4a5b
Inflate flex container's padding by using the union of flex items' normal position margin boxes. r=dholbert

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/29131 for changes under testing/web-platform/tests

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c786a99f4a5b

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot