Closed Bug 1712930 Opened 3 years ago Closed 3 years ago

Get rid of most of NS_ERROR_DOM_INVALID_STATE_XHR_*

Tracking

()

Status:

RESOLVED FIXED

Milestone:

91 Branch

Tracking Flags:

Tracking

Status

firefox91

---

fixed

People

(Reporter: edgar, Assigned: edgar)

References

Details

Attachments

(7 files)

Bug 1712930 - Part 1: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_CHUNKED_RESPONSETYPES_UNSUPPORTED_FOR_SYNC; r=smaug 3 years ago Edgar Chen [:edgar] 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1712930 - Part 2: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_HAS_WRONG_RESPONSETYPE_FOR_RESPONSETEXT; r=smaug 3 years ago Edgar Chen [:edgar] 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1712930 - Part 3: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_HAS_WRONG_RESPONSETYPE_FOR_RESPONSEXML; r=smaug 3 years ago Edgar Chen [:edgar] 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1712930 - Part 4: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_MUST_NOT_BE_LOADING_OR_DONE_OVERRIDE_MIME_TYPE; r=smaug 3 years ago Edgar Chen [:edgar] 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1712930 - Part 5: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_MUST_NOT_BE_LOADING_OR_DONE_RESPONSE_TYPE; r=smaug 3 years ago Edgar Chen [:edgar] 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1712930 - Part 6: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_MUST_NOT_BE_SENDING; r=smaug 3 years ago Edgar Chen [:edgar] 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1712930 - Part 7: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_MUST_BE_OPENED; r=smaug 3 years ago Edgar Chen [:edgar] 48 bytes, text/x-phabricator-request		Details \| Review

Edgar Chen [:edgar]

Assignee

Description

•

3 years ago

Except NS_ERROR_DOM_INVALID_STATE_XHR_HAS_INVALID_CONTEXT which is returned by OnStartRequest in https://searchfox.org/mozilla-central/rev/202250ee5931648185c8abb3061d738b15b64067/dom/xhr/XMLHttpRequestMainThread.cpp#2015, not sure if we could replace it by other generic error.

Edgar Chen [:edgar]

Assignee

Comment 1

•

3 years ago

Attached file Bug 1712930 - Part 1: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_CHUNKED_RESPONSETYPES_UNSUPPORTED_FOR_SYNC; r=smaug — Details

Edgar Chen [:edgar]

Assignee

Comment 2

•

3 years ago

Attached file Bug 1712930 - Part 2: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_HAS_WRONG_RESPONSETYPE_FOR_RESPONSETEXT; r=smaug — Details

Depends on D116075

Edgar Chen [:edgar]

Assignee

Comment 3

•

3 years ago

Attached file Bug 1712930 - Part 3: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_HAS_WRONG_RESPONSETYPE_FOR_RESPONSEXML; r=smaug — Details

Depends on D116076

Edgar Chen [:edgar]

Assignee

Comment 4

•

3 years ago

Attached file Bug 1712930 - Part 4: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_MUST_NOT_BE_LOADING_OR_DONE_OVERRIDE_MIME_TYPE; r=smaug — Details

Depends on D116077

Edgar Chen [:edgar]

Assignee

Comment 5

•

3 years ago

Attached file Bug 1712930 - Part 5: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_MUST_NOT_BE_LOADING_OR_DONE_RESPONSE_TYPE; r=smaug — Details

Depends on D116078

Edgar Chen [:edgar]

Assignee

Comment 6

•

3 years ago

Attached file Bug 1712930 - Part 6: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_MUST_NOT_BE_SENDING; r=smaug — Details

Depends on D116079

Edgar Chen [:edgar]

Assignee

Comment 7

•

3 years ago

Attached file Bug 1712930 - Part 7: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_MUST_BE_OPENED; r=smaug — Details

Depends on D116080

Pulsebot

Comment 8

•

3 years ago

Pushed by echen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6f842a2bf026
Part 1: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_CHUNKED_RESPONSETYPES_UNSUPPORTED_FOR_SYNC; r=smaug
https://hg.mozilla.org/integration/autoland/rev/78e1d6847f0a
Part 2: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_HAS_WRONG_RESPONSETYPE_FOR_RESPONSETEXT; r=smaug
https://hg.mozilla.org/integration/autoland/rev/d2eb6df1ec5f
Part 3: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_HAS_WRONG_RESPONSETYPE_FOR_RESPONSEXML; r=smaug
https://hg.mozilla.org/integration/autoland/rev/b2da173c9337
Part 4: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_MUST_NOT_BE_LOADING_OR_DONE_OVERRIDE_MIME_TYPE; r=smaug
https://hg.mozilla.org/integration/autoland/rev/36e48f6e43ae
Part 5: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_MUST_NOT_BE_LOADING_OR_DONE_RESPONSE_TYPE; r=smaug
https://hg.mozilla.org/integration/autoland/rev/f1cb609c78a0
Part 6: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_MUST_NOT_BE_SENDING; r=smaug
https://hg.mozilla.org/integration/autoland/rev/4b93e808e72f
Part 7: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_MUST_BE_OPENED; r=smaug

Noemi Erli[:noemi_erli]

Comment 9

•

3 years ago

Backed out 7 changesets (Bug 1712930) for causing Android mochitest failures in test_onerror_message.html

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=Y86RqWNxTDir9gS5cSroQQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=4b93e808e72f837e140c230adafb42ba0075300d

Log: https://treeherder.mozilla.org/logviewer?job_id=341098706&repo=autoland&lineNumber=2999

Backout: https://hg.mozilla.org/integration/autoland/rev/d2c03d09d79630fb04459fc6e0d2d23caca2a12b

Flags: needinfo?(echen)

Edgar Chen [:edgar]

Assignee

Comment 10

•

3 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=82109748510eb131f7e5224850b1145efc706984

Flags: needinfo?(echen)

Pulsebot

Comment 11

•

3 years ago

Pushed by echen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ec01575cb276
Part 1: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_CHUNKED_RESPONSETYPES_UNSUPPORTED_FOR_SYNC; r=smaug
https://hg.mozilla.org/integration/autoland/rev/ab9bb2ee0c98
Part 2: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_HAS_WRONG_RESPONSETYPE_FOR_RESPONSETEXT; r=smaug
https://hg.mozilla.org/integration/autoland/rev/dd0ab5fc70a0
Part 3: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_HAS_WRONG_RESPONSETYPE_FOR_RESPONSEXML; r=smaug
https://hg.mozilla.org/integration/autoland/rev/b117c37b1e7e
Part 4: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_MUST_NOT_BE_LOADING_OR_DONE_OVERRIDE_MIME_TYPE; r=smaug
https://hg.mozilla.org/integration/autoland/rev/c42f2270b5f8
Part 5: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_MUST_NOT_BE_LOADING_OR_DONE_RESPONSE_TYPE; r=smaug
https://hg.mozilla.org/integration/autoland/rev/311ccf17a01d
Part 6: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_MUST_NOT_BE_SENDING; r=smaug
https://hg.mozilla.org/integration/autoland/rev/4a03c8b2aa1a
Part 7: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_MUST_BE_OPENED; r=smaug

Sandor Molnar[:smolnar]

Comment 12

•

3 years ago

Backed out for causing damp failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/a8c952dcf42810501dbce59333fdd5867e9a1804

Push with failures

Failure log

Flags: needinfo?(echen)

Edgar Chen [:edgar]

Assignee

Comment 13

•

3 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=80fa982676b5baac122ff5a118085497bcb7e5a8

Flags: needinfo?(echen)

Pulsebot

Comment 14

•

3 years ago

Pushed by echen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0c02937c3f06
Part 1: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_CHUNKED_RESPONSETYPES_UNSUPPORTED_FOR_SYNC; r=smaug
https://hg.mozilla.org/integration/autoland/rev/c752980af6a5
Part 2: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_HAS_WRONG_RESPONSETYPE_FOR_RESPONSETEXT; r=smaug
https://hg.mozilla.org/integration/autoland/rev/ea09ede6ea97
Part 3: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_HAS_WRONG_RESPONSETYPE_FOR_RESPONSEXML; r=smaug
https://hg.mozilla.org/integration/autoland/rev/738fa39cb56c
Part 4: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_MUST_NOT_BE_LOADING_OR_DONE_OVERRIDE_MIME_TYPE; r=smaug
https://hg.mozilla.org/integration/autoland/rev/56a24b0ce175
Part 5: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_MUST_NOT_BE_LOADING_OR_DONE_RESPONSE_TYPE; r=smaug
https://hg.mozilla.org/integration/autoland/rev/9ccb11577a00
Part 6: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_MUST_NOT_BE_SENDING; r=smaug
https://hg.mozilla.org/integration/autoland/rev/133d2832d07c
Part 7: Get rid of NS_ERROR_DOM_INVALID_STATE_XHR_MUST_BE_OPENED; r=smaug,perftest-reviewers,sparky

Atila Butkovits

Comment 15

•

3 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/0c02937c3f06
https://hg.mozilla.org/mozilla-central/rev/c752980af6a5
https://hg.mozilla.org/mozilla-central/rev/ea09ede6ea97
https://hg.mozilla.org/mozilla-central/rev/738fa39cb56c
https://hg.mozilla.org/mozilla-central/rev/56a24b0ce175
https://hg.mozilla.org/mozilla-central/rev/9ccb11577a00
https://hg.mozilla.org/mozilla-central/rev/133d2832d07c

Status: NEW → RESOLVED

Closed: 3 years ago

status-firefox91: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 91 Branch

Landry Breuil (:gaston)

Comment 16

•

3 years ago

Fwiw this caused a build failure (probably only on platforms without profiler), for missing definition of MakeScopeExit, cf https://bugzilla.mozilla.org/show_bug.cgi?id=1713564#c7

adding the missing ScopeExit.h header inclusion as done in https://hg.mozilla.org/integration/autoland/rev/1c110c9d06c3 seem to help.

Petr Sumbera

Updated

•

3 years ago

Regressions: 1714022

Kershaw Chang [:kershaw]

Updated

•

3 years ago

Regressions: 1714224

You need to log in before you can comment on or make changes to this bug.