Closed Bug 1714022 Opened 3 years ago Closed 3 years ago

XMLHttpRequestMainThread.cpp:3050:22: error: MakeScopeExit was not declared in this scope

Categories

(Core :: DOM: Networking, defect, P3)

defect

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox88 --- unaffected
firefox89 --- unaffected
firefox90 --- unaffected
firefox91 --- fixed

People

(Reporter: petr.sumbera, Assigned: gaston)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:88.0) Gecko/20100101 Firefox/88.0

Steps to reproduce:

Build on platforms without profiler fails again with:

11:25.59 In file included from Unified_cpp_dom_xhr0.cpp:20:
11:25.59 /builds/psumbera/mozilla-central-build/dom/xhr/XMLHttpRequestMainThread.cpp: In member function void mozilla::dom::XMLHttpRequestMainThread::SendInternal(const moz illa::dom::BodyExtractorBase*, bool, mozilla::ErrorResult&):
11:25.59 /builds/psumbera/mozilla-central-build/dom/xhr/XMLHttpRequestMainThread.cpp:3050:22: error: MakeScopeExit was not declared in this scope; did you mean scopeExit
?
11:25.59  3050 |     auto scopeExit = MakeScopeExit([&] {
11:25.59       |                      ^~~~~~~~~~~~~
11:25.59       |                      scopeExit

This is probably regression after: Bug 1712930.

Mike, please, is there any chance how to avoid these?

Flags: needinfo?(mh+mozilla)
Keywords: regression
Regressed by: 1712930
Has Regression Range: --- → yes

The Bugbug bot thinks this bug should belong to the 'Core::XPCOM' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: Untriaged → XPCOM
Product: Firefox → Core

btw https://phabricator.services.mozilla.com/D116560 will fix this one, dunno how one can change the bug number on an existing review..

(In reply to Landry Breuil (:gaston) from comment #3)

btw https://phabricator.services.mozilla.com/D116560 will fix this one, dunno how one can change the bug number on an existing review..

You can change the bug number in the commit message locally and re-submit to phabricator again, it will link to the new bug automatically.

Severity: -- → S3
Component: XPCOM → DOM: Networking
Priority: -- → P3
Assignee: nobody → petr.sumbera
Assignee: petr.sumbera → landry

Fixes build failure on Tier3:
src/m-c/dom/xhr/XMLHttpRequestMainThread.cpp:3050:22: error: use of undeclared identifier 'MakeScopeExit'
auto scopeExit = MakeScopeExit([&] {
regressed by bug 1712930

Set release status flags based on info from the regressing bug 1712930

Status: UNCONFIRMED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch

(In reply to Petr Sumbera from comment #1)

Mike, please, is there any chance how to avoid these?

See bug 1712231

Flags: needinfo?(mh+mozilla)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: