Closed Bug 1713145 Opened 3 years ago Closed 3 years ago

messages.getFull can not decode body of nntp message

Tracking

(thunderbird_esr78 wontfix)

Status:

RESOLVED FIXED

Milestone:

91 Branch

Tracking Flags:

Tracking

Status

thunderbird_esr78

---

wontfix

People

(Reporter: manikulin, Assigned: TbSync)

Details

Attachments

(2 files, 2 obsolete files)

Bug 1713145 - Fix encoding errors in MimeParser.extractMimeMsg(). r=mkmelin 3 years ago John Bieling (:TbSync) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1713145 - Fix encoding errors in MimeParser.extractMimeMsg() and properly decode headers in messages.getFull WebExtension API. r=mkmelin 3 years ago John Bieling (:TbSync) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1713145 - Fix MimeParser.extractMimeMsg() to return the same headers as MsgHdrToMimeMessage, properly return inline body parts and fix multiple decoding issues in the messages.getFull WebExtension API. r=mkmelin 3 years ago John Bieling (:TbSync) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1713145 - Also test content at root part of multipart/alternative emails for messages.getFull API. r=mkmelin 3 years ago John Bieling (:TbSync) 48 bytes, text/x-phabricator-request		Details \| Review

max

Reporter

Description

•

3 years ago

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:88.0) Gecko/20100101 Firefox/88.0

Steps to reproduce:

MimeParser.extractMimeMsg introduced in Bug #1644027 for messages.getFull is unable to properly decode UTF-8 body or message part having quoted-printable or base64 transfer encoding. The issue is specific to nntp messages, e.g. messages from local folders are decoded correctly.

Minimal example using code from implementation of messages.getFull. Inspect output in console after loading of the following extension:

background.js

browser.tst.decode(
`From - Thu May 27 21:23:35 2021
Newsgroups: gmane.comp.mozilla.thundebird.user
From: Bug Reporter <new@thunderbird.bug>
Subject: =?UTF-8?B?zrHOu8+GzqzOss63z4TOvw==?=
Date: Thu, 27 May 2021 21:23:35 +0100
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8;
Content-Transfer-Encoding: base64

zobOu8+GzrEK
`).then(msg => {
	console.log(msg);
	console.log(msg.headers['subject']);
	console.log(msg.parts[0].body);
}).catch(console.error);

experiment.js

var { MimeParser } = ChromeUtils.import("resource:///modules/mimeParser.jsm");

function convertMessagePart(part) {
  let partObject = {};
  for (let key of [
    "body",
    "contentType",
    "headers",
    "name",
    "partName",
    "size",
  ]) {
    if (key in part) {
      partObject[key] = part[key];
    }
  }
  if ("parts" in part && Array.isArray(part.parts) && part.parts.length > 0) {
    partObject.parts = part.parts.map(convertMessagePart);
  }
  return partObject;
}
var tst = class extends ExtensionCommon.ExtensionAPI {
	getAPI(context) {
		return { tst: {
			async decode(raw) {
				let mimeMsg = {};
				try {
					mimeMsg = MimeParser.extractMimeMsg(raw, {
						includeAttachments: false,
					});
				} catch (e) {
					console.log(MimeParser);
					console.error(e);
					throw new Error('Message decode error');
				}
				return convertMessagePart(mimeMsg);
			}
		} };
	}
};

schema.json

[ {
	"namespace": "tst",
	"functions": [ {
		"name": "decode",
		"type": "function",
		"async": true,
		"parameters": [ { "name": "raw", "type": "string" } ]
	} ]
} ]

manifest.json

{
	"manifest_version": 2,
	"name": "getFull decoder test",
	"version": "0.1",
	"background": { "scripts": [ "background.js" ] },
	"experiment_apis": { "tst": {
		"schema": "schema.json",
		"parent": {
			"scopes": [ "addon_parent" ],
			"paths": [ [ "tst" ] ],
			"script": "experiment.js"
		}
	} }
}

Actual results:

Headers (Subject) are decoded correctly.
Garbage instead of body text. Representation is different in object inspector (msg) and for body printed by console.log.

Expected results:

Body: "Άλφα"