1713247 - Extract CardDAV discovery code so it can be reused

Status: RESOLVED FIXED

(MailNews Core :: Address Book, task)

Description

[Geoff Lankow (:darktrojan)]

CardDAV discovery is tied to the dialog box for creating a directory, but it should be accessible to the account set-up tab. In this bug I'll pull it and some other things out into a utility file.

Comment 1

[Alessandro Castellani [:aleca]]

Thank you so much for this, let me know if I can help in any way.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1713247 - Move common CardDAV functions into a separate file. r=mkmelin

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1713247 - Extract CardDAV discovery code so it can be reused. r=mkmelin

Depends on D116333

Comment 4

[Geoff Lankow (:darktrojan)]

Even with these changes we still can't detect Google address books (or calendars, for that matter) without asking for authorisation again. I think I know what to do about that but I'll deal with it separately.

Comment 5

[Magnus Melin [:mkmelin]]

I guess it's good to get this in before the merge...

Comment 6

[Geoff Lankow (:darktrojan)]

Hold that thought, I've found a problem.

Comment 7

[Geoff Lankow (:darktrojan)]

Okay, I think we're good now. I've restored the old behaviour of always prompting for a username/password, even if there is one saved. Also I noticed that the username field wasn't disabled while looking for address books, so I fixed that too.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/beca85fcc20e
Move common CardDAV functions into a separate file. r=mkmelin
https://hg.mozilla.org/comm-central/rev/5010bb05ba31
Extract CardDAV discovery code so it can be reused. r=mkmelin