1713280 - [Mac] In folder pane focused, selected folder with new message almost unreadable

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

Since bug 1712469 we use the highlight background on a focused, selected folder. This works very good until there is a new message in it (blue text on blue background with default highlight colour). We need to follow what we do on Linux and Windows and force to use then the highlightText text colour.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1713280-mac-new-selected-focus-treeitem-ESR.patch

This is the patch for ESR but still applies on trunk too and you can test it easily. For trunk I have a special patch which unifies this styles.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: 1713280-unify-new-selected-focus-treeitem.patch

Patch for trunk. It unifies the rules of folderPane.css.

Comment 3

[Alessandro Castellani [:aleca]]

Comment on attachment 9223961 [details] [diff] [review]
1713280-unify-new-selected-focus-treeitem.patch

Review of attachment 9223961 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks for the clean up.

Comment 4

[Richard Marti (:Paenglab)]

Comment on attachment 9223958 [details] [diff] [review]
1713280-mac-new-selected-focus-treeitem-ESR.patch

[Approval Request Comment]
User impact if declined: treeitem almost unreadable when focused with new messages
Testing completed (on c-c, etc.): soon on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fc1ae8df94a9
Unify the new, selected and focused treeitem styles. r=aleca

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9223958 [details] [diff] [review]
1713280-mac-new-selected-focus-treeitem-ESR.patch

[Triage Comment]
Approved for esr78

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 78.12.0:
https://hg.mozilla.org/releases/comm-esr78/rev/82a04332a1de