1713938 - "toggle-screenshot-disable" notification disables/enables screenshot toolbar button in all windows

Status: RESOLVED FIXED

(Firefox :: Screenshots, defect, P2)

Description

[Shane Hughes [:aminomancer]]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

• Put the screenshot widget in your customizable navbar.
• Go to some page you can screenshot and press ctrl+shift+S.
• Observe that the screenshot toolbar button is disabled.
• Press ctrl + N to open a new window.
• Close the new window to go back to the first window, whose selected tab should still be in "screenshot mode".

Actual results:

• The screenshot toolbar button is not disabled anymore.
• Press Esc to leave screenshot mode.
• Open another new window and, in that window, go to a page you can screenshot and press ctrl+shift+S or click the screenshot toolbar button.
• Now alt+tab back to the original window, without exiting "screenshot mode" or closing the new window.
• Observe that the screenshot button is now disabled even though that window doesn't have any tabs in screenshot mode.
• Press ctrl+shift+S to enter screenshot mode since you can no longer click the toolbar widget.
• Button stays disabled in both windows.
• Press Esc.
• Alt+tab back to the 2nd window, it's still in screenshot mode but its toolbar widget is now enabled again.
• I guess you could do this a million ways lol, I'm just trying to be thorough.

Expected results:

• The "toggle-screenshot-disable" observer notification should include (as the subject) either the window from which it was notified, or the selected browser from the time and execution context of the notification.
• Right now the subject is just null. See here and here.
• If it wasn't null, then this observer could check that subj === window or subj === gBrowser.selectedBrowser before setting/removing the disabled attribute.

Comment 1

[Kajal Sah]

Attachment: Bug 1713938 - Corrects toggle-screenshot-disable button. r?emalysz

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab936b7f0c9f
Corrects toggle-screenshot-disable button. r=emalysz

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/ab936b7f0c9f