Closed Bug 1714344 Opened 3 years ago Closed 3 years ago

[Phase 2] The QuickSuggest results are no longer triggered after upgrading from Firefox 89 to 90 while enrolled in the experiment

Categories

(Firefox :: Address Bar, defect, P1)

Desktop
All
defect
Points:
2

Tracking

()

VERIFIED FIXED
91 Branch
Iteration:
91.1 - May 31 - Jun 13
Tracking Status
firefox90 --- verified
firefox91 --- verified

People

(Reporter: cmuntean, Assigned: nanj)

References

Details

Attachments

(2 files)

[Notes]:

  • Not sure if there are some changes in Firefox 90 that are not supported by the Nimbus experiment that might cause this.

  • While typing a keyword that should trigger a QS result the following error is displayed in browser console: Error: Trying to access an unknown pref quickSuggestSponsoredIndex.

  • I have managed to reproduce this only while enrolled in the Nimbus experiment. If I manually set the following prefs on Firefox 89 release, the issue is not reproducible:
    -"browser.urlbar.quicksuggest.enabled" = "true";
    -"browser.urlbar.quicksuggest.ShouldShowOnboardingDialog" = "false";
    -"browser.urlbar.experimental.firefoxSuggestLabels.enabled" = "true";
    -"browser.urlbar.quicksuggest.showOnboardingDialogAfterNRestarts" = "2";

  • This can be concerning if the Firefox Suggest - Phase 2 timeline will be extended and will be included in Firefox 90.

  • Unfortunately, Firefox Suggest - Phase 3 is not ready and we cannot confirm if this issue is also reproducible for it.

  • Also, I am not sure if this happens because we don't use the normal flow to update the Firefox versions.

[Affected versions]:

  • Firefox Beta 90.0b2;
  • Firefox Release 89.0;

[Affected Platforms]:

  • Windows 10 x64;
  • macOS 10.15.7;
  • Linux Mint 20 x64;

[Prerequisites]:

  • Have the latest Firefox 89.0 release installed.
  • Have a Beta 90.0b2 that has the channel changed to "release".
  • If you are not on US region, use a VPN service and connect to a US region.
  • Have the following prefs set to ve enrolled in Firefox Suggest - Phase 2:
  • "messaging-system.rsexperimentloader.collection_id" to "nimbus-preview".
  • "app.normandy.user_id" to "7ea78579-c421-034f-8b54-1f7e04d826bb".
  • "messaging-system.log" to "all".

[Steps to reproduce]:

  1. Open the Firefox release with the profile from prerequisites.
  2. Click on the Awesome bar and type "nike" and observe the results.
  3. Close the browser.
  4. Open Firefox Beta 90.0b2 with the same profile used above.
  5. Click on the Awesome bar and type "nike" and observe the results.

[Expected result]:
Step 2: The Nike Sponsored result is displayed in the last position.
Step 5: The Nike Sponsored result is displayed in the last position.

[Actual result]:
Step 2: The Nike Sponsored result is displayed in the last position.
Step 5: The Nike Sponsored result is NOT displayed. An Error: Trying to access an unknown pref quickSuggestSponsoredIndex error is displayed in the browser console while typing a keyword that should trigger a QS.

[Additional Notes]:

  • Attached a screen recording of the issue.
Flags: needinfo?(adw)

I did some digging, looks like NimbusFeature.getValue is deprecated, we should use getAllVariables.

Will put up a patch for this.

Assignee: nobody → najiang

Thanks for reporting this, Cosmin!

This issue has been fixed by adding those missing "variables" to the Nimbus recipes (v1 and v2). Cosmin also verified those new recipes with Firefox 89, they worked as expected.

My patch replaces the deprecated Nimbus function calls in the Urlbar codebase with the new replacements. After confirming with :andreio, we don't need to uplift this to Fx 90 as long as we define all the variables in the experiment recipe.

Flags: needinfo?(adw)

Thanks Nan.

Status: NEW → ASSIGNED
Priority: -- → P1

(In reply to Nan Jiang [:nanj] from comment #3)

After confirming with :andreio, we don't need to uplift this to Fx 90 as long as we define all the variables in the experiment recipe.

I'll mark 90 as wontfix and 91 as affected.

Iteration: --- → 91.1 - May 31 - Jun 13
Pushed by najiang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9935ac592157
Replace the deprecated Nimbus.url.getValue calls r=adw,andreio,preferences-reviewers,jaws
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch

I have verified this issue by updating Firefox 89 to Firefox 90 on Windows 10 x64, macOS 10.15.7 and Linux Mint 20. I have also verified it by updating Firefox 90 to 91.

  • The QuickSuggest results are correctly triggered after updating the Firefox browser.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: