1714376 - Replace a number of "exception.message" usages

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, defect)

Description

[Andrey Bienkowski]

This is a contribution toward fixing https://bugzilla.mozilla.org/show_bug.cgi?id=1713825

In PEP 352, exception.message was deprecated (now, you can get the string from of an exception by simply doing str(exception). As of Python 3.0, exception.message was dropped, and attempting to access it causes an error.

• This patch fixes many instances of exception.message, but there are still some remaining
• ./mach lint --fix made a bunch of formatting changes to code I did not touch

Comment 1

[Andrey Bienkowski]

Attachment: Bug 1714376 - Replace a number of "exception.message" usages. r=mhentges

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68f73772f51e
Replace a number of "exception.message" usages. r=mhentges,jgraham

Comment 3

[Dorel Luca [:dluca]]

Backed out changeset 68f73772f51e (bug 1714376) for Xpcom failures in builds/worker/checkouts/gecko/xpcom/idl-parser/xpidl/runtests.py. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=341678941&repo=autoland&lineNumber=443

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=68f73772f51e4a57c0c5ac39648630a9e4604e51

Backout:
https://hg.mozilla.org/integration/autoland/rev/9b4996e620cde5629f86c0539258786462ac8530

Comment 4

[Andrey Bienkowski]

I was able to repro locally. Will push a fix soon. BTW can I haz level 1 commit access to push to try? Me being able to run the entire Firefox testsuite w/o making my own workstation unusable would save everyone time.

Comment 5

[Andrey Bienkowski]

The test should pass now.

Comment 6

[Mitchell Hentges [:mhentges] 🦀]

Thanks for the fix, though let's do a try run before landing this.
I'd recommend following this guide to get level 1 access - link me/NI me on the bug and I'll vouch for you 👍

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/167c07857eb9
Replace a number of "exception.message" usages. r=mhentges,jgraham

Comment 8

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/29282 for changes under testing/web-platform/tests

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/167c07857eb9

Comment 10

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot