1714407 - Fix the signals sent to the anti-tracking UI when we shim or unblock requests

Status: VERIFIED FIXED

(Core :: Privacy: Anti-Tracking, defect)

Description

[Thomas Wisniewski [:twisniewski]]

The fix in bug 1712562 crossed some proverbial wires, and the UI is not consistently informed when a given request has been unblocked by a user opt-in. The fix is straightforward.

Comment 1

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1714407 - fix a regression caused by bug 1714407 where SmartBlock does not always properly inform the anti-tracking UI when users opt into allowing specific content; r?pbz,ksenia

Three changes here:

• fix the experimental API to check for the "allow" case first, then the "replace" signal
• update the JSON config for the two opt-in shims so they know to also mark the relevant requests as allowed, not just replaced/shimmed
• remove a pointless (unused) unblocksOnOptIn line

Comment 2

[Thomas Wisniewski [:twisniewski]]

Comment on attachment 9225026 [details]
Bug 1714407 - fix a regression caused by bug 1714407 where SmartBlock does not always properly inform the anti-tracking UI when users opt into allowing specific content; r?pbz,ksenia

Beta/Release Uplift Approval Request

• User impact if declined: Users who specifically investigate which tracker domains are being blocked on a given private browsing/strict ETP tab will not consistently see which trackers they have opted into allowing by using SmartBlock.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1) open a new private browsing tab.

2. visit https://www.patreon.com/login
3. click on the "continue with Facebook" login button (the popup window may be closed afterward)
4. click on the Firefox Shield icon in the URL bar
5. confirm that in the "tracking content" section, there are blue icons:
   a) at the top of the section, next to text like "some trackers have been unblocked"
   b) beside the connect.facebook.com URL in the list below
6. Reload the same Patreon login tab
7. repeat step 5, confirm the blue icons are still present (the list of URLs may be slightly different).

• List of other uplifts needed: Bug 1714180
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Low risk, as this change only affects SmartBlock, and only when users specifically opt into allowing certain trackers.

QE testing is optional, as these STR are being added to our QE test-plan for SmartBlock releases (including of PI-1033 in JIRA for Fx90). A local build has been tested with these STR, and behaves as expected.

• String changes made/needed: none

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf8aca33c53a
fix a regression caused by bug 1714407 where SmartBlock does not always properly inform the anti-tracking UI when users opt into allowing specific content; r=pbz,ksenia,webcompat-reviewers

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/bf8aca33c53a

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1712562

Comment 6

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox 91.0a1 (2021-06-04) on Windows 10 x64, macOS 10.15 and on Ubuntu 20.04.

Comment 7

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 9225026 [details]
Bug 1714407 - fix a regression caused by bug 1714407 where SmartBlock does not always properly inform the anti-tracking UI when users opt into allowing specific content; r?pbz,ksenia

approved for 90.0b5

Comment 8

[Julien Cristau [:jcristau] (back April 22)]

https://hg.mozilla.org/releases/mozilla-beta/rev/f34504963aab

Comment 9

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox 90.0b5 on Windows 10 x64, macOS 10.15 and on Ubuntu 20.04.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5c1de409877
[components] Bug 1714407 - Import v23.3.0 of feature-webcompat.