1714577 - Teach WebRTC.org to use the Gecko Profiler

Status: RESOLVED FIXED

(Core :: WebRTC, enhancement)

Comment 1

[Paul Adenot (:padenot)]

Attachment: Bug 1714577 - Part 1 - Include the Gecko Profiler include directory in WebRTC.org files. r?ng

Comment 2

[Paul Adenot (:padenot)]

Attachment: Bug 1714577 - Part 2 - Introduction of the micro gecko profiler API. r?gerald

This allows using the Gecko Profiler without pulling in half of Gecko (nsTArray,
nsString, etc.). This is for use in third party code, that we lightly patch to
register the threads.

Depends on D116838

Comment 3

[Paul Adenot (:padenot)]

Attachment: Bug 1714577 - Part 3 - Register WebRTC threads with the Gecko Profiler. r?ng

This is the only change that is needed, and is trivial to rebase if this file
changes. I don't know if there is value in providing the raw patch file
alongside this commit, like we sometimes do?

Depends on D116839

Comment 4

[Paul Adenot (:padenot)]

Attachment: Bug 1714577 - Part 4 - Regenerate `moz.build` files to add the new include directory. r?ng

This is just ./mach build-backend -b GnMozbuildWriter with the change in Part 1.

Depends on D116840

Comment 5

[Paul Adenot (:padenot)]

Attachment: Bug 1714577 - Part 5 - Add GeckoTraceEvent.h to clang-format-ignore. r?ng

We're going to modify it, but it will cause unnecessary churn to reformat it to
Gecko style (it would change all indentation, etc.), in case we want to update
it with upstream.

Depends on D116841

Comment 6

[Paul Adenot (:padenot)]

Attachment: Bug 1714577 - Part 6 - Copy WebRTC's trace_event.h to Gecko, verbatim, and redirect the original trace_event.h to it. r?ng,gerald

Depends on D116842

Comment 7

[Paul Adenot (:padenot)]

Attachment: Bug 1714577 - Part 7 - Add a function to insert a very simple profiler marker in the micro gecko profiler. r?gerald

Depends on D116843

Comment 8

[Paul Adenot (:padenot)]

Attachment: Bug 1714577 - Part 8 - Modify GeckoTraceEvent.h to use the micro gecko profiler API. r?gerald

Depends on D116844

Comment 9

[Paul Adenot (:padenot)]

Attachment: Bug 1714577 - Part 9 - Video capture code also has tracing macros. r?ng

Depends on D116845

Comment 10

[Paul Adenot (:padenot)]

Attachment: Bug 1714577 - Part 10 - Add (some?) WebRTC threads to the firefox profiler. r?julienw

Depends on D116846

Comment 11

[Paul Adenot (:padenot)]

Attachment: webrtc-profile-decode.png

This is how it looks like in the end, when using the profile Media and recording a WebRTC call.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79db0c37af56
Part 1 - Include the Gecko Profiler include directory in WebRTC.org files. r=ng
https://hg.mozilla.org/integration/autoland/rev/b2767ca4b806
Part 2 - Introduction of the micro gecko profiler API. r=gerald
https://hg.mozilla.org/integration/autoland/rev/7c5c4bce1b36
Part 3 - Register WebRTC threads with the Gecko Profiler. r=ng
https://hg.mozilla.org/integration/autoland/rev/782e6df9b4c8
Part 4 - Regenerate `moz.build` files to add the new include directory. r=ng
https://hg.mozilla.org/integration/autoland/rev/e805cbb61030
Part 5 - Add GeckoTraceEvent.h to clang-format-ignore. r=gerald
https://hg.mozilla.org/integration/autoland/rev/837b6ce8367b
Part 6 - Copy WebRTC's trace_event.h to Gecko, verbatim, and redirect the original trace_event.h to it. r=gerald
https://hg.mozilla.org/integration/autoland/rev/e296aab6c841
Part 7 - Add a function to insert a very simple profiler marker in the micro gecko profiler. r=gerald
https://hg.mozilla.org/integration/autoland/rev/258640cc1188
Part 8 - Modify GeckoTraceEvent.h to use the micro gecko profiler API. r=gerald
https://hg.mozilla.org/integration/autoland/rev/2b9472a516eb
Part 9 - Video capture code also has tracing macros. r=ng
https://hg.mozilla.org/integration/autoland/rev/cd6d06ee89dd
Part 10 - Add (some?) WebRTC threads to the firefox profiler.  r=julienw,gerald

Comment 13

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/79db0c37af56
https://hg.mozilla.org/mozilla-central/rev/b2767ca4b806
https://hg.mozilla.org/mozilla-central/rev/7c5c4bce1b36
https://hg.mozilla.org/mozilla-central/rev/782e6df9b4c8
https://hg.mozilla.org/mozilla-central/rev/e805cbb61030
https://hg.mozilla.org/mozilla-central/rev/837b6ce8367b
https://hg.mozilla.org/mozilla-central/rev/e296aab6c841
https://hg.mozilla.org/mozilla-central/rev/258640cc1188
https://hg.mozilla.org/mozilla-central/rev/2b9472a516eb
https://hg.mozilla.org/mozilla-central/rev/cd6d06ee89dd