1715844 - undefined reference to `uprofiler_unregister_thread()'

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect, P2)

Description

[Dan Horák]

I am getting an "undefined reference to uprofiler_unregister_thread()" error at the final linking stage after a recent change (last day or two, my last build on Tue was OK) on Fedora/34 on ppc64le. More details will follow.

...
1:52.34 /usr/bin/ld: /mnt/dan/firefox.git/obj-powerpc64le-unknown-linux-gnu/toolkit/library/build/../../../third_party/libwebrtc/webrtc/rtc_base/rtc_base_approved_generic_gn/Unified_cpp__approved_generic_gn1.o: in function `AutoRegisterProfiler::AutoRegisterProfiler(char const*, char*)':
 1:52.34 /mnt/dan/firefox.git/tools/profiler/public/MicroGeckoProfiler.h:25: undefined reference to `uprofiler_register_thread(char const*, void*)'
 1:52.34 /usr/bin/ld: /mnt/dan/firefox.git/obj-powerpc64le-unknown-linux-gnu/toolkit/library/build/../../../third_party/libwebrtc/webrtc/rtc_base/rtc_base_approved_generic_gn/Unified_cpp__approved_generic_gn1.o: in function `AutoRegisterProfiler::~AutoRegisterProfiler()':
 1:52.34 /mnt/dan/firefox.git/tools/profiler/public/MicroGeckoProfiler.h:27: undefined reference to `uprofiler_unregister_thread()'
 1:52.34 /usr/bin/ld: /mnt/dan/firefox.git/tools/profiler/public/MicroGeckoProfiler.h:27: undefined reference to `uprofiler_unregister_thread()'
 2:08.60 /usr/bin/ld: libxul.so: hidden symbol `_Z25uprofiler_register_threadPKcPv' isn't defined
 2:08.60 /usr/bin/ld: final link failed: bad value
 2:08.87 collect2: error: ld returned 1 exit status

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Bug 1714577 introduced uprofiler_unregister_thread() and friends. I'm guessing there may be missing #ifdef MOZ_GECKO_PROFILERs.

It's :padenot 's night now, and I have experience (sigh) with this kind of issues, so I'll have a look.

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1715844 - Fixed non-MOZ_GECKO_PROFILER build of MicroGeckoProfiler - r?canaltinova,padenot

Comment 3

[Petr Sumbera]

Just for record. I don't see this problem on Solaris.

Comment 4

[Dan Horák]

I confirm the proposed patch fixes my build problem on ppc64le.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab6c5301aed1
Fixed non-MOZ_GECKO_PROFILER build of MicroGeckoProfiler - r=canaltinova

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1714577

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/ab6c5301aed1