build mozilla trunk with gtk2 fails in gfx/src/gtk/nsGdkUtils.cpp

VERIFIED FIXED

Status

()

VERIFIED FIXED
17 years ago
17 years ago

People

(Reporter: jay.yan, Assigned: tetsuroy)

Tracking

({intl})

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

497 bytes, text/plain
yinbolian
: review+
Details
(Reporter)

Description

17 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.0) Gecko/20020529
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.0) Gecko/20020529

bug 169695's regression. Bstell moved some code from nsRenderingContextGTK.h to
a new file nsGdkUtils.cpp, the new file can compile sucessfully in gtk1 env, but
not for gtk2.

Reproducible: Always

Steps to Reproduce:
(Reporter)

Comment 1

17 years ago
add reviewers here.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: build mozilla trunk with gtk2 failed in gfx/src/gtk/nsGdkUtils.cpp → build mozilla trunk with gtk2 fails in gfx/src/gtk/nsGdkUtils.cpp
(Reporter)

Comment 2

17 years ago
Created attachment 101028 [details]
patch

a simple fix to make the new file compile with gtk2 enviroment
(Reporter)

Updated

17 years ago
Attachment #101028 - Attachment description: 171461 → patch
(Reporter)

Updated

17 years ago
Blocks: 92033
(Reporter)

Comment 3

17 years ago
->Jay
Status: NEW → ASSIGNED

Comment 4

17 years ago
Comment on attachment 101028 [details]
patch

r=bolian
Attachment #101028 - Flags: review+
(Reporter)

Comment 6

17 years ago
verified.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
(Reporter)

Comment 7

17 years ago
tested the patch and building works well now.
Status: RESOLVED → VERIFIED
I just included gdkx.h which is safe on gtk 1.2 and pulls in all the X headers
anyway.

Updated

17 years ago
Keywords: intl
You need to log in before you can comment on or make changes to this bug.