1714632 - Firefox does not support Unicode Emoji v13.0 or higher

Status: VERIFIED FIXED

(Core :: Graphics: Text, defect)

Description

[rugk]

Attachment: emoji-test-13.html

Steps to reproduce:

Open the attached emoji-test.html on Windows/macOS. (Some Linux'es may ship with their own updated emoji sets making this bug not reproducible.)

Actual results:

emoji 13.0 combined with ZWJ are shown as two emojis
and not all Emojis are shown at all

Expected results:

display all emojis https://emojipedia.org/emoji-13.0/

"Downstream" bug of my add-on at https://github.com/rugk/awesome-emoji-picker/issues/116

Comment 1

[rugk]

Attachment: image-as-shown-on-windows.png

Bug as shown on Windows.

Comment 2

[rugk]

Image as shown on Windows

Comment 3

[rugk]

This is a follow-up report of bug 1644346 (same now solved issue with previous Unicode emoji version) and it's on your si8te likely blocked by https://github.com/mozilla/twemoji-colr/issues/54 and https://github.com/mozilla/twemoji-colr/issues/58

Comment 4

[rugk]

Arg Bugzilla. Now reported this emojis detroying bug in Bug 1714635, but anyway here is the test file as a GitHub gist: https://gist.github.com/rugk/71cadef3b8a8f18909c4f3f4e649121e

Comment 5

[Jamie Nicol [:jnicol] (on leave until 21st October)]

Jonathan, it looks like you handled this for the previous update, are you able to do the same again?

Comment 6

[Jonathan Kew [:jfkthame]]

This is dependent on https://github.com/mozilla/twemoji-colr/issues/58 being addressed; if someone submits a PR there, we should be able to integrate it pretty easily. I'll try to get around to it if nobody else does, but may take some time -- I haven't attempted a build of this font for a very long time, and not sure of the state of toolchains etc.

Comment 7

[Teal Dulcet [:tdulcet] (TB Council)]

(In reply to Jonathan Kew (:jfkthame) from comment #6)

if someone submits a PR there, we should be able to integrate it pretty easily.

Someone submitted a pull request: https://github.com/mozilla/twemoji-colr/pull/59.

Comment 9

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1714632 - Update bundled TwemojiMozilla font to 0.6.0 (Twemoji 13.1). r=lsalzman

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9a2b3e113ba
Update bundled TwemojiMozilla font to 0.6.0 (Twemoji 13.1). r=lsalzman

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e9a2b3e113ba

Comment 12

[Teal Dulcet [:tdulcet] (TB Council)]

Can this please be uplifted to Firefox 91 Beta, so that it makes it into 91 ESR and Thunderbird 91, so those users do not have to wait another year for Emoji v13/13.1.

Comment 13

[Pascal Chevrel:pascalc]

Jonathan, is that something we could safely uplift into 91 beta or should it bake on nightly before evaluating an uplift to the ESR91 branch? Thanks

Comment 14

[Jonathan Kew [:jfkthame]]

I think it'd be fine to uplift this, given that it'll be helpful for ESR/TB; it's just a font update, the risk should be pretty minimal.

Comment 15

[Jonathan Kew [:jfkthame]]

Comment on attachment 9231617 [details]
Bug 1714632 - Update bundled TwemojiMozilla font to 0.6.0 (Twemoji 13.1). r=lsalzman

Beta/Release Uplift Approval Request

• User impact if declined: Recently-encoded emoji characters/sequences don't display.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just a font update based on new Twemoji from upstream.
• String changes made/needed:

Comment 16

[Pascal Chevrel:pascalc]

Comment on attachment 9231617 [details]
Bug 1714632 - Update bundled TwemojiMozilla font to 0.6.0 (Twemoji 13.1). r=lsalzman

Low risk font change, approved for 91 beta 6, thanks.

Comment 17

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/9d94415e2e4e

Comment 18

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: Screenshot 2021-07-23 at 10.36.17 1.png

Reproduced the issue with Firefox 91.0a1 (20210604213013) on Windows 10x64.
The issue is verified fixed with Firefox 92.0a1 and 91.0b6 on Windows 10x64. The Unicode Emojis from the attached test case is displayed as expected after using "Repair text encoding". However, I see that the emojis are not displayed on macOS 10.15 with 91.0b6 and 92.0a1 (20210604213013). Should we file a new bug for this or reopen this one. Thank you!

Comment 19

[Jonathan Kew [:jfkthame]]

TwemojiMozilla font issues are relevant only on Windows and Linux, as these are the platforms where we bundle this font.

On macOS we rely on the installed Apple emoji font. The emojis in the testcase display as expected on macOS 11.4 (Big Sur). So there's nothing further to do here.

Comment 20

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Thank you Jonathan!

Verified on Ubuntu 18.04 with 91.0b6 and 92.0a1 as well. The emojis are displayed as expected. Closing this as verified based on the above.