1714681 - Broken menu popups with gfx.xrender.enabled=true

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Oriol Brufau [:Oriol]]

Attachment: screencast-white-menu.gif

1. Set gfx.xrender.enabled=true. May require a restart.
2. Click the hamburg menu

Expected: you see the menu
Actual: just some white area

Regression window: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=62e5068e45fd905fdb563245cad4efec1d8c0ac0&tochange=1646c323910d1f2438a60d9326903acf443542b9. That's bug 1699224.

I have Lubuntu 18.04.

Comment 1

[Oriol Brufau [:Oriol]]

Attachment: firefox-crash.gif

BTW, the exit button in the hamburguer menu still seems to do its job even when you can't see it.
But if you click a bit above that (the help button, I guess), then Firefox crashes.
https://crash-stats.mozilla.org/report/index/7d7991b8-5ab5-470e-b84c-9dbfe0210606

Comment 2

[Pascal Chevrel:pascalc]

Can we get a severity set to this bug? Is that something common enough that we should work on a fix for 90 or for an 89 dot release? Thanks

Comment 3

[Jamie Nicol [:jnicol]]

XRender is not enabled by default so I wouldn't think this should require a dot release. Though uplifting a fix for 90 may make sense.

Oriol, could you please attach a copy of your about:support information? I presume the rendering issue only occurs with xrender enabled, but is that also the case for the crash in comment 1?

Comment 4

[Oriol Brufau [:Oriol]]

The problem has been fixed in https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a60835242de7a032a0223f906a96569dcfe82d52&tochange=808da1d9c00b1efe8affbd64702ed6155e612f96

That's bug 1712047, which I don't have access to. Please make sure to uplift it.

Comment 5

[Oriol Brufau [:Oriol]]

Attachment: graphics-info.txt

That's my graphics info anyways, taken from 2021-06-09 (which includes the fix).

The crash in comment 1 required gfx.xrender.enabled=true and is also fixed now.

Comment 6

[Jeff Muizelaar [:jrmuizel]]

Great. That what I hoped would happen.

As an aside, why do you use gfx.xrender.enabled?

Comment 7

[Oriol Brufau [:Oriol]]

OK, also fixed in beta https://hg.mozilla.org/releases/mozilla-beta/rev/e33597d2ca99eef625b927c646ebcc4840c80de3

(In reply to Jeff Muizelaar [:jrmuizel] from comment #6)

As an aside, why do you use gfx.xrender.enabled?

I don't remember, I just had it enabled for some reason, and when updating to 89 I noticed the menus were broken.

Comment 8

[Jamie Nicol [:jnicol]]

(In reply to Oriol Brufau [:Oriol] from comment #4)

The problem has been fixed in https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a60835242de7a032a0223f906a96569dcfe82d52&tochange=808da1d9c00b1efe8affbd64702ed6155e612f96

That's bug 1712047, which I don't have access to. Please make sure to uplift it.

The patch has already landed in beta, and will ride along for a dot release. Marking this as fixed.

Comment 9

[Jeff Muizelaar [:jrmuizel]]

(In reply to Oriol Brufau [:Oriol] from comment #7)

OK, also fixed in beta https://hg.mozilla.org/releases/mozilla-beta/rev/e33597d2ca99eef625b927c646ebcc4840c80de3

(In reply to Jeff Muizelaar [:jrmuizel] from comment #6)

As an aside, why do you use gfx.xrender.enabled?

I don't remember, I just had it enabled for some reason, and when updating to 89 I noticed the menus were broken.

I'd suggest turning it off. It's not a configuration that we want to support.