[Windows 10] Can't delete bookmark separators in menus
Categories
(Firefox :: Bookmarks & History, defect, P3)
Tracking
()
People
(Reporter: rielname, Assigned: bigiri)
References
(Blocks 1 open bug)
Details
(Keywords: regression, Whiteboard: [proton-cleanups])
Attachments
(1 file)
User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/87.0.4280.88 Safari/537.36 OPR/73.0.3856.284 (Edition Yx 03)
Steps to reproduce:
Created a bookmark separator in the newest version of Firefox (89.0 64-bit)
Actual results:
I tried to delete it but it would not delete
Expected results:
It should have deleted!
Comment 1•3 years ago
|
||
The Bugbug bot thinks this bug should belong to the 'Firefox::Bookmarks & History' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.
Comment 2•3 years ago
|
||
I can reproduce the issue on Windows10.
It is almost impossible to delete.
The hit point area against the separator seems too narrow.
See screencast https://youtu.be/ChxcjJUpydw. It took more than a dozen right clicks near the separator to bring up the context menu for Delete
menu.
(In reply to Alice0775 White from comment #2)
I can reproduce the issue on Windows10.
It is almost impossible to delete.
The hit point area against the separator seems too narrow.See screencast https://youtu.be/ChxcjJUpydw. It took more than a dozen right clicks near the separator to bring up the context menu for
Delete
menu.
You are a lifesaber
Comment 4•3 years ago
|
||
(In reply to Alice0775 White from comment #2)
I can reproduce the issue on Windows10.
It is almost impossible to delete.
The hit point area against the separator seems too narrow.See screencast https://youtu.be/ChxcjJUpydw. It took more than a dozen right clicks near the separator to bring up the context menu for
Delete
menu.
Why did you mark this as blocking proton? Is this a proton regression? (That would kind of surprise me.)
Comment 5•3 years ago
|
||
non-proton(Firefox87): the menuseparator is 5px in height
menuseparator {
appearance: auto;
-moz-default-appearance: menuseparator;
padding: 3px 1px 4px;
border-top: 1px solid ThreeDShadow;
border-bottom: 1px solid ThreeDHighlight;
}
proton(Nightly91): the menuseparator is only 1px in height
menuseparator {
appearance: none;
border-top: 1px solid var(--menu-border-color);
border-bottom: none;
padding: 0;
margin: 2px 1em;
}
So, I blocked the proton context.
Comment 6•3 years ago
|
||
OK, thanks for clarifying. I was mostly confused because the toolbar separators haven't been touched, and from comment #0 it was not clear to me this was about the ones in menus.
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 7•3 years ago
|
||
Proton removed the default HR appearance and replaced padding with margins. Unfortunately margins are not clickable. So this patch replaces margins with padding while maintaining the look of proton on Windows, MacOS, and Linux. Doing this required a few CSS tricks.
Updated•3 years ago
|
Comment 9•3 years ago
|
||
bugherder |
Updated•3 years ago
|
Updated•3 years ago
|
Comment 10•3 years ago
|
||
Given the dependencies involved, I'm not sure we should try backporting this to ESR91. If you want to provide a rebased patch, however, we can consider it.
Comment 11•3 years ago
|
||
Description
•