1714870 - [tb78 only] Invisible folder display

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[andrewm57]

Attachment: tbird-folder.mp4

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.77 Safari/537.36

Steps to reproduce:

Downloaded release update Mac 78.11.0 installed and restarted
Rebooted OSX 10.12.6

Actual results:

Any selected folder is invisible on the folder display pane.

Expected results:

Folder should be visible.

Comment 1

[Richard Marti (:Paenglab)]

I can't test OS X 10.12.6 but also on Big Sur the highlight background isn't shown. Regression from bug 1712469: TB 78 has not appearance but -moz-appearance.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: 1714870-moz-appearance-ESR.patch

This was my oversight. I was so used to use appearance that I forgot that 78 doesn't support it.

Comment 3

[Alessandro Castellani [:aleca]]

Comment on attachment 9225471 [details] [diff] [review]
1714870-moz-appearance-ESR.patch

Review of attachment 9225471 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, this is correct.
My mistake as well for not checking the 78 uplift on all platforms.
Thanks.

Comment 4

[Richard Marti (:Paenglab)]

Comment on attachment 9225471 [details] [diff] [review]
1714870-moz-appearance-ESR.patch

[Approval Request Comment]
Regression caused by (bug #): bug 1712469
User impact if declined: on Mac not visible selected folder
Testing completed (on c-c, etc.): no c-c issue
Risk to taking this patch (and alternatives if risky): low

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9225471 [details] [diff] [review]
1714870-moz-appearance-ESR.patch

[Triage Comment]
Approved for esr78

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 78.12.0:
https://hg.mozilla.org/releases/comm-esr78/rev/a78469bb67b5

Comment 7

[Magnus Melin [:mkmelin]]

I guess this can be closed.