1715120 - [autoconfig] "Select protocol" with no protocols to select

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect, P1)

Description

[Ben Bucksch (:BenB)]

Environment:

• TB 91 Nightly of 2021-07-07

Reproduction:

• Start new profile and start the account creation dialog.
• Enter an email address, e.g. [e-mail] . The domain should have only IMAP or POP3 servers, but not both. This is the case for qq.com.
• Enter "nonsense" as password
• Click Continue

Actual result:

• "Configuration found in Mozilla ISP database" in green
• "Select the protocol" heading
• There is no protocol to select
• You can still click Done, and it works.

Expected result:

• "Select the protocol" does not appear, if there is only one protocol to select
• The found configuration and particularly the hostname is shown in all cases, even if there is only 1 configuration.

Importance:
Showing the hostnames (incoming and outgoing) before connecting the first time is a very important security feature, to inform the user where we will send the password. Showing the hostname is a critical and indispensible part in the entire flow.

Cause:
This is a regression from the recent account creation dialog re-work. It beautified the IMAP vs. POP3 selector - which looks nice -, but clearly forgot the case where only 1 result came back, probably due lack of test cases and mere oversight.

Comment 1

[Ben Bucksch (:BenB)]

Attachment: Screenshot

Comment 2

[Alessandro Castellani [:aleca]]

Ouch, my bad.
Thanks for the detailed overview.
I'll take care of this right away and a test to cover this use case.

Comment 3

[Alessandro Castellani [:aleca]]

Attachment: Bug 1715120 - Show all account protocols even if only one is available. r=mkmelin

Comment 4

[Alessandro Castellani [:aleca]]

Try run: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=b860a3e77da925323a1667bf642dc64c937c50eb

Comment 5

[Ben Bucksch (:BenB)]

Comment on attachment 9225754 [details]
Bug 1715120 - Show all account protocols even if only one is available. r=mkmelin

Thanks, Alec!

Very elegant, with the label choice using the count.
Wording: How about "Available configuration" for the one case?
r=BenB otherwise

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4982222b4d3e
Show all account protocols even if only one is available. r=mkmelin

Comment 7

[Ben Bucksch (:BenB)]

Thank you! :-)

Comment 8

[Rob Lemley [:rjl]]

Comment on attachment 9225754 [details]
Bug 1715120 - Show all account protocols even if only one is available. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): 1697575
User impact if declined: Visually incomplete UI when only one protocol is supported by a mail server
Testing completed (on c-c, etc.): test case added
Risk to taking this patch (and alternatives if risky):
low risk as would only affect setting up new accounts, and fix has been vetted on nightly

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9225754 [details]
Bug 1715120 - Show all account protocols even if only one is available. r=mkmelin

[Triage Comment]
Approved for beta

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 90.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/ab4d0d3cec5f