Open Bug 1715607 Opened 1 year ago Updated 16 days ago

Hover area of shortcut tile should be clickable.

Categories

(Firefox :: New Tab Page, defect, P3)

defect

Tracking

()

ASSIGNED

People

(Reporter: amy, Assigned: eghbalniakian)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(2 files, 2 obsolete files)

Attached image shortcut-click-area.png

Shortcut tiles hover state shows a larger background area that should also be clickable.

Summary: Entire hover area of shortcuts should be clickable. → Hover area of shortcut tile should be clickable.
Priority: -- → P3
Mentor: achurchwell
Keywords: good-first-bug

Hey I'm an Outreachy applicant could I please work on these issue? Regards, Jane

hello I'm beginner I want to fix this bug as my first contribution, can anyone pls guide me??

Hi, I would like to fix this bug and make the entire area clickable. Can I be assigned this task please?

Flags: needinfo?(achurchwell)

(In reply to Evgenia Kotovich from comment #1)

Hey I'm an Outreachy applicant could I please work on these issue? Regards, Jane

Hello! You are welcome to work on this issue. Feel free to ask questions here on the bug, and/or you can also ask in Matrix (the #introduction channel is a great place to start.) You can find the quick reference for contributing to Firefox here.

Note that for the New Tab Page you will have to bundle the CSS before you can see your changes. Run ./mach npm run bundle --prefix=browser/components/newtab. More information here.

Thanks for your help! :-)

Assignee: nobody → jenyabrentnall
Flags: needinfo?(achurchwell)

(In reply to Bhasker from comment #2)

hello I'm beginner I want to fix this bug as my first contribution, can anyone pls guide me??

Hey Bhasker I have started already working on other bug last night so this one all yours for grabbing if you'd like! Sorry for late response

(In reply to Evgenia Kotovich from comment #5)

(In reply to Bhasker from comment #2)

hello I'm beginner I want to fix this bug as my first contribution, can anyone pls guide me??

Hey Bhasker I have started already working on other bug last night so this one all yours for grabbing if you'd like! Sorry for late response

hey thanks , I had build the firefox environment installed android studio wat to do next

Assignee: jenyabrentnall → baskerron
Status: NEW → ASSIGNED

Hi Bhasker, this is a Firefox Desktop bug, not Android. Do you have a desktop build set up locally?
You can find more information here.

Flags: needinfo?(baskerron)

madam I had done with desktop build set up locally

Flags: needinfo?(baskerron)

madam sorry I got exam time table Im not getting time so pls de-assign me

Assignee: baskerron → nobody
Status: ASSIGNED → NEW

I'm an Outreach applicant, can you assign this to me?

(In reply to thecoderhuman from comment #10)

I'm an Outreach applicant, can you assign this to me?

Assigned!

Assignee: nobody → thecoderhuman
Status: NEW → ASSIGNED

Are you still working on this / do you need any help?

Flags: needinfo?(thecoderhuman)

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Assignee: thecoderhuman → nobody
Status: ASSIGNED → NEW
Assignee: nobody → eghbalniakian
Status: NEW → ASSIGNED
Attachment #9263258 - Attachment is obsolete: true

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Assignee: eghbalniakian → nobody
Status: ASSIGNED → NEW
Assignee: nobody → eghbalniakian
Status: NEW → ASSIGNED

Amy, I get the following error from the linter

273:7 error Anchor used as a button. Anchors are primarily expected to navigate. Use the button element instead. Learn more: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/HEAD/docs/rules/anchor-is-valid.md jsx-a11y/anchor-is-valid (eslint)

However, it seems like I am using the <a> in pretty much exactly the same way as before, what do you suggest?

Flags: needinfo?(achurchwell)
Attachment #9263396 - Attachment is obsolete: true
Mentor: achurchwell
Flags: needinfo?(achurchwell)

Hi Dale, does anyone on your team have bandwidth to mentor this bug?

Flags: needinfo?(dharvey)

By the way dharvey, I realized I simply needed to silence the warning, as was done to the anchor tag before I moved it. So I think its good to go, although I may need to rebase.

Redirect a needinfo that is pending on an inactive user to the triage owner.
:daleharvey, since the bug has recent activity, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(thecoderhuman) → needinfo?(dharvey)

Looks like it needs some linting fixed but glad its fixed, feel free to ping if you need anything from me although not a peer on that code so probably not the best for review

Flags: needinfo?(dharvey)

Sorry, there was a problem with the detection of inactive users. I'm reverting the change.

Assignee: nobody → eghbalniakian
Status: NEW → ASSIGNED
You need to log in before you can comment on or make changes to this bug.