Closed Bug 1715607 Opened 3 years ago Closed 29 days ago

Hover area of shortcut tile should be clickable.

Categories

(Firefox :: New Tab Page, defect, P3)

defect

Tracking

()

RESOLVED FIXED
124 Branch
Tracking Status
firefox124 --- fixed

People

(Reporter: amy, Assigned: nbarrett)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Whiteboard: [hnt])

Attachments

(3 files, 3 obsolete files)

Attached image shortcut-click-area.png

Shortcut tiles hover state shows a larger background area that should also be clickable.

Summary: Entire hover area of shortcuts should be clickable. → Hover area of shortcut tile should be clickable.
Priority: -- → P3
Mentor: achurchwell
Keywords: good-first-bug

Hey I'm an Outreachy applicant could I please work on these issue? Regards, Jane

hello I'm beginner I want to fix this bug as my first contribution, can anyone pls guide me??

Hi, I would like to fix this bug and make the entire area clickable. Can I be assigned this task please?

Flags: needinfo?(achurchwell)

(In reply to Evgenia Kotovich from comment #1)

Hey I'm an Outreachy applicant could I please work on these issue? Regards, Jane

Hello! You are welcome to work on this issue. Feel free to ask questions here on the bug, and/or you can also ask in Matrix (the #introduction channel is a great place to start.) You can find the quick reference for contributing to Firefox here.

Note that for the New Tab Page you will have to bundle the CSS before you can see your changes. Run ./mach npm run bundle --prefix=browser/components/newtab. More information here.

Thanks for your help! :-)

Assignee: nobody → jenyabrentnall
Flags: needinfo?(achurchwell)

(In reply to Bhasker from comment #2)

hello I'm beginner I want to fix this bug as my first contribution, can anyone pls guide me??

Hey Bhasker I have started already working on other bug last night so this one all yours for grabbing if you'd like! Sorry for late response

(In reply to Evgenia Kotovich from comment #5)

(In reply to Bhasker from comment #2)

hello I'm beginner I want to fix this bug as my first contribution, can anyone pls guide me??

Hey Bhasker I have started already working on other bug last night so this one all yours for grabbing if you'd like! Sorry for late response

hey thanks , I had build the firefox environment installed android studio wat to do next

Assignee: jenyabrentnall → baskerron
Status: NEW → ASSIGNED

Hi Bhasker, this is a Firefox Desktop bug, not Android. Do you have a desktop build set up locally?
You can find more information here.

Flags: needinfo?(baskerron)

madam I had done with desktop build set up locally

Flags: needinfo?(baskerron)

madam sorry I got exam time table Im not getting time so pls de-assign me

Assignee: baskerron → nobody
Status: ASSIGNED → NEW

I'm an Outreach applicant, can you assign this to me?

(In reply to thecoderhuman from comment #10)

I'm an Outreach applicant, can you assign this to me?

Assigned!

Assignee: nobody → thecoderhuman
Status: NEW → ASSIGNED

Are you still working on this / do you need any help?

Flags: needinfo?(thecoderhuman)

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Assignee: thecoderhuman → nobody
Status: ASSIGNED → NEW
Assignee: nobody → eghbalniakian
Status: NEW → ASSIGNED
Attachment #9263258 - Attachment is obsolete: true

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Assignee: eghbalniakian → nobody
Status: ASSIGNED → NEW
Assignee: nobody → eghbalniakian
Status: NEW → ASSIGNED

Amy, I get the following error from the linter

273:7 error Anchor used as a button. Anchors are primarily expected to navigate. Use the button element instead. Learn more: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/HEAD/docs/rules/anchor-is-valid.md jsx-a11y/anchor-is-valid (eslint)

However, it seems like I am using the <a> in pretty much exactly the same way as before, what do you suggest?

Flags: needinfo?(achurchwell)
Attachment #9263396 - Attachment is obsolete: true
Mentor: achurchwell
Flags: needinfo?(achurchwell)

Hi Dale, does anyone on your team have bandwidth to mentor this bug?

Flags: needinfo?(dharvey)

By the way dharvey, I realized I simply needed to silence the warning, as was done to the anchor tag before I moved it. So I think its good to go, although I may need to rebase.

Redirect a needinfo that is pending on an inactive user to the triage owner.
:daleharvey, since the bug has recent activity, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(thecoderhuman) → needinfo?(dharvey)

Looks like it needs some linting fixed but glad its fixed, feel free to ping if you need anything from me although not a peer on that code so probably not the best for review

Flags: needinfo?(dharvey)

Sorry, there was a problem with the detection of inactive users. I'm reverting the change.

Assignee: nobody → eghbalniakian
Status: NEW → ASSIGNED

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Assignee: eghbalniakian → nobody
Status: ASSIGNED → NEW

I really tried to submit some code. I made it trough the bootstrap, the build, the run, but slowly got a ton of errors and could see no changes on the app... have read the source docs, but couldn't actually found something useful for my specific, several errors:
JavaScript error: resource://gre/modules/TerminatorTelemetry.jsm, line 94: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsITelemetry.getHistogramById]
[2022-10-10T20:46:30Z ERROR glean_core::metrics::ping] Invalid reason code startup for ping newtab
console.error: BackgroundUpdate:
_reasonsToNotScheduleUpdates: Failed to check for Maintenance Service Registry Key: [Exception... "Component returned failure code: 0x80004001 (NS_ERROR_NOT_IMPLEMENTED) [nsIUpdateProcessor.getServiceRegKeyExists]" nsresult: "0x80004001 (NS_ERROR_NOT_IMPLEMENTED)" location: "JS frame :: resource://gre/modules/BackgroundUpdate.jsm :: _reasonsToNotScheduleUpdates :: line 253" data: no]
console.error: (new Error("Target already destroyed, unable to fetch children fronts", "resource://devtools/client/fronts/targets/target-mixin.js", 327))
console.error: "Exception when calling onAvailable handler" "Target already destroyed, unable to fetch children fronts" (new Error("Target already destroyed, unable to fetch children fronts", "resource://devtools/client/fronts/targets/target-mixin.js", 327))
:(

CSS-only: Moved the padding from the outer list item .top-site-outer to the inner link .top-site-outer .top-site-inner > a -- this inner a was contrained by the parent's padding

Assignee: nobody → jamienk
Status: NEW → ASSIGNED

I think the previous attempts to fix this bug misunderstood the issue. It's simply a CSS issue: the parent li had padding, so the child a couldn't fill the entire inside of the li -- by moving the padding inside the a the entire top site is clickable, including the padding.

review ping

Flags: needinfo?(gvnplm)

(In reply to Jamie Katz from comment #29)

review ping

Think you meant :gvn, moving the needinfo for you.

Flags: needinfo?(gvnplm) → needinfo?(gsuntop)

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Assignee: jamienk → nobody
Status: ASSIGNED → NEW

As an Outreachy aspirant, kindly assign this task to me!

I am working on this problem!

Looks like this is a good first bug but has no mentor assigned. Dale, can you mentor this or find someone else who can? Thank you!

Flags: needinfo?(dharvey)

Hello, can I take this as my first bug? If yes, can you guide me?

Hi Hanna! wanted to give this bug a shot but i dont think there is a mentor assigned. could you please help me out with this. thank you!

Flags: needinfo?(hjones)

Hey Siya - I would wait until a mentor is assigned on this bug so it's clear who you can request a review from (I'll defer to :daleharvey or :gvn on that). I'm not too familiar with this part of Firefox, so I can't speak to whether or not this is still a change we want to or need to make.

Flags: needinfo?(hjones)
Flags: needinfo?(gsuntop)
Assignee: nobody → jamienk
Status: NEW → ASSIGNED

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.

Assignee: jamienk → nobody
Status: ASSIGNED → NEW

Clearing newtab backlog as I am no longer triage owner (apologies for very late replies)

Flags: needinfo?(dharvey)

OK, without a mentor, let's just not treat this as a good first bug then.

Keywords: good-first-bug
Assignee: nobody → nbarrett
Severity: -- → S3
Whiteboard: [hnt]
Pushed by achurchwell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e0ab6e106cd8
Make TopSite hover area clickable r=amy,desktop-theme-reviewers
Status: NEW → RESOLVED
Closed: 29 days ago
Resolution: --- → FIXED
Target Milestone: --- → 124 Branch
Attachment #9313113 - Attachment is obsolete: true
Regressions: 1878747
Depends on: 1882471
You need to log in before you can comment on or make changes to this bug.