Hover area of shortcut tile should be clickable.
Categories
(Firefox :: New Tab Page, defect, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox124 | --- | fixed |
People
(Reporter: amy, Assigned: nbarrett)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
(Whiteboard: [hnt])
Attachments
(3 files, 3 obsolete files)
Shortcut tiles hover state shows a larger background area that should also be clickable.
Reporter | ||
Updated•3 years ago
|
Reporter | ||
Updated•3 years ago
|
Reporter | ||
Updated•3 years ago
|
Comment 1•3 years ago
|
||
Hey I'm an Outreachy applicant could I please work on these issue? Regards, Jane
hello I'm beginner I want to fix this bug as my first contribution, can anyone pls guide me??
Comment 3•3 years ago
|
||
Hi, I would like to fix this bug and make the entire area clickable. Can I be assigned this task please?
Reporter | ||
Comment 4•3 years ago
|
||
(In reply to Evgenia Kotovich from comment #1)
Hey I'm an Outreachy applicant could I please work on these issue? Regards, Jane
Hello! You are welcome to work on this issue. Feel free to ask questions here on the bug, and/or you can also ask in Matrix (the #introduction channel is a great place to start.) You can find the quick reference for contributing to Firefox here.
Note that for the New Tab Page you will have to bundle the CSS before you can see your changes. Run ./mach npm run bundle --prefix=browser/components/newtab
. More information here.
Thanks for your help! :-)
Comment 5•3 years ago
|
||
(In reply to Bhasker from comment #2)
hello I'm beginner I want to fix this bug as my first contribution, can anyone pls guide me??
Hey Bhasker I have started already working on other bug last night so this one all yours for grabbing if you'd like! Sorry for late response
(In reply to Evgenia Kotovich from comment #5)
(In reply to Bhasker from comment #2)
hello I'm beginner I want to fix this bug as my first contribution, can anyone pls guide me??
Hey Bhasker I have started already working on other bug last night so this one all yours for grabbing if you'd like! Sorry for late response
hey thanks , I had build the firefox environment installed android studio wat to do next
Reporter | ||
Updated•3 years ago
|
Reporter | ||
Updated•3 years ago
|
Reporter | ||
Comment 7•3 years ago
|
||
Hi Bhasker, this is a Firefox Desktop bug, not Android. Do you have a desktop build set up locally?
You can find more information here.
madam I had done with desktop build set up locally
madam sorry I got exam time table Im not getting time so pls de-assign me
Reporter | ||
Updated•3 years ago
|
Comment 10•3 years ago
|
||
I'm an Outreach applicant, can you assign this to me?
Reporter | ||
Comment 11•3 years ago
|
||
(In reply to thecoderhuman from comment #10)
I'm an Outreach applicant, can you assign this to me?
Assigned!
Comment 12•3 years ago
|
||
Are you still working on this / do you need any help?
Comment 13•3 years ago
|
||
This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.
Comment 14•3 years ago
|
||
Updated•3 years ago
|
Comment 15•3 years ago
|
||
Updated•3 years ago
|
Comment 16•3 years ago
|
||
This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.
Updated•2 years ago
|
Comment 17•2 years ago
|
||
Comment 18•2 years ago
|
||
Amy, I get the following error from the linter
273:7 error Anchor used as a button. Anchors are primarily expected to navigate. Use the button element instead. Learn more: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/HEAD/docs/rules/anchor-is-valid.md jsx-a11y/anchor-is-valid (eslint)
However, it seems like I am using the <a> in pretty much exactly the same way as before, what do you suggest?
Updated•2 years ago
|
Reporter | ||
Updated•2 years ago
|
Reporter | ||
Comment 19•2 years ago
|
||
Hi Dale, does anyone on your team have bandwidth to mentor this bug?
Comment 20•2 years ago
|
||
By the way dharvey, I realized I simply needed to silence the warning, as was done to the anchor tag before I moved it. So I think its good to go, although I may need to rebase.
Comment 21•2 years ago
|
||
Redirect a needinfo that is pending on an inactive user to the triage owner.
:daleharvey, since the bug has recent activity, could you have a look please?
For more information, please visit auto_nag documentation.
Comment 22•2 years ago
|
||
Looks like it needs some linting fixed but glad its fixed, feel free to ping if you need anything from me although not a peer on that code so probably not the best for review
Comment hidden (off-topic) |
Comment 24•2 years ago
|
||
Sorry, there was a problem with the detection of inactive users. I'm reverting the change.
Comment 25•2 years ago
|
||
This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.
Comment 26•2 years ago
|
||
I really tried to submit some code. I made it trough the bootstrap, the build, the run, but slowly got a ton of errors and could see no changes on the app... have read the source docs, but couldn't actually found something useful for my specific, several errors:
JavaScript error: resource://gre/modules/TerminatorTelemetry.jsm, line 94: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsITelemetry.getHistogramById]
[2022-10-10T20:46:30Z ERROR glean_core::metrics::ping] Invalid reason code startup for ping newtab
console.error: BackgroundUpdate:
_reasonsToNotScheduleUpdates: Failed to check for Maintenance Service Registry Key: [Exception... "Component returned failure code: 0x80004001 (NS_ERROR_NOT_IMPLEMENTED) [nsIUpdateProcessor.getServiceRegKeyExists]" nsresult: "0x80004001 (NS_ERROR_NOT_IMPLEMENTED)" location: "JS frame :: resource://gre/modules/BackgroundUpdate.jsm :: _reasonsToNotScheduleUpdates :: line 253" data: no]
console.error: (new Error("Target already destroyed, unable to fetch children fronts", "resource://devtools/client/fronts/targets/target-mixin.js", 327))
console.error: "Exception when calling onAvailable handler" "Target already destroyed, unable to fetch children fronts" (new Error("Target already destroyed, unable to fetch children fronts", "resource://devtools/client/fronts/targets/target-mixin.js", 327))
:(
Comment 27•2 years ago
|
||
CSS-only: Moved the padding from the outer list item .top-site-outer
to the inner link .top-site-outer .top-site-inner > a
-- this inner a
was contrained by the parent's padding
Updated•2 years ago
|
Comment 28•2 years ago
|
||
I think the previous attempts to fix this bug misunderstood the issue. It's simply a CSS issue: the parent li
had padding, so the child a
couldn't fill the entire inside of the li
-- by moving the padding inside the a
the entire top site is clickable, including the padding.
Comment 30•2 years ago
|
||
(In reply to Jamie Katz from comment #29)
review ping
Think you meant :gvn, moving the needinfo for you.
Comment 31•2 years ago
|
||
This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.
Comment 32•2 years ago
|
||
As an Outreachy aspirant, kindly assign this task to me!
Comment 33•2 years ago
|
||
I am working on this problem!
Comment 34•2 years ago
|
||
Looks like this is a good first bug
but has no mentor assigned. Dale, can you mentor this or find someone else who can? Thank you!
Comment 35•2 years ago
|
||
Hello, can I take this as my first bug? If yes, can you guide me?
Comment 36•2 years ago
|
||
Hi Hanna! wanted to give this bug a shot but i dont think there is a mentor assigned. could you please help me out with this. thank you!
Comment 37•1 year ago
|
||
Hey Siya - I would wait until a mentor is assigned on this bug so it's clear who you can request a review from (I'll defer to :daleharvey or :gvn on that). I'm not too familiar with this part of Firefox, so I can't speak to whether or not this is still a change we want to or need to make.
Updated•1 year ago
|
Updated•1 year ago
|
Comment 38•1 year ago
|
||
This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.
Comment 39•1 year ago
|
||
Clearing newtab backlog as I am no longer triage owner (apologies for very late replies)
Comment 40•1 year ago
|
||
OK, without a mentor, let's just not treat this as a good first bug then.
Reporter | ||
Updated•8 months ago
|
Updated•8 months ago
|
Assignee | ||
Comment 41•8 months ago
|
||
Comment 42•8 months ago
|
||
Pushed by achurchwell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e0ab6e106cd8 Make TopSite hover area clickable r=amy,desktop-theme-reviewers
Comment 43•8 months ago
|
||
bugherder |
Updated•8 months ago
|
Description
•