Open Bug 1715676 Opened 3 years ago Updated 2 years ago

Remove the PushRoundedRect function?

Categories

(Core :: Web Painting, enhancement, P3)

Product:
Core
Component:
Web Painting
Type:
enhancement

Tracking

()

People

(Reporter: MatsPalmgren_bugz, Unassigned)

References

Details

Bug 1542807 will remove nsBulletFrame, which is used by gfx/tests/reftest/1681610.html to test the PushRoundedRect function. I've commented out that test in the reftest.list manifest file for now, in case you want to try to rewrite this test in some other way.

AFAICT, there's only one other caller of PushRoundedRect in the tree:
https://searchfox.org/mozilla-central/rev/b52cf6bbe214bd9d93ed9333d0403f7d556ad7c8/layout/generic/nsImageFrame.cpp#1696,1724
which says "If we could not draw the icon, just draw some graffiti in the mean time." so presumably it's not important what graffiti we draw there so perhaps we could eliminate it/replace it with something else?

If so, then we could remove PushRoundedRect and the test altogether.

Severity: -- → S3
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.