1542807 - Remove legacy layout code path for ::marker (nsBulletFrame)

Status: RESOLVED FIXED

(Core :: Layout, task, P2)

Description

[Mats Palmgren (inactive)]

We should make 'list-style-type/image' markers take the same
code path as we take for 'content' markers. Then we can
remove nsBulletFrame since it's dead code.

I think this change would also fix the listed blocked bugs.

Comment 1

[Sean Voisen (:svoisen)]

Now that we triage by severity, setting this bug's priority to P2 to represent near-term backlog status. See https://wiki.mozilla.org/Platform/Layout#Backlog_Tracking_in_Bugzilla

Comment 2

[Mats Palmgren (inactive)]

Attachment: bullets in various fonts

Comment 3

[Mats Palmgren (inactive)]

Attachment: Bug 1542807 part 1 - Create generated content and use normal box construction for list-style-type/list-style-image ::markers. r=emilio

I've filed a CSSWG issue on the change from 0x25FE to 0x25AA for
list-style-type:square here:
https://github.com/w3c/csswg-drafts/issues/6200

Comment 4

[Mats Palmgren (inactive)]

Attachment: Bug 1542807 part 2 - Remove (now unused) nsBulletFrame. r=emilio

Depends on D111691

Comment 5

[Mats Palmgren (inactive)]

Attachment: Bug 1542807 part 3 - Add some style quirks for legacy ::markers created from list-style-type/list-style-image. r=emilio

Specifically:
For "bullets", i.e. 'list-style-type:disc|circle|square|
disclosure-closed|disclosure-open', we use a built-in font
(-moz-bullet-font, which has glyphs for those symbols + space) to
retain mostly backwards compatible rendering for those. Authors may
override that with an explicit 'font-family' ::marker style though.
We also use this font for 'list-style-image' in case it would
fallback to one of the above when the image fails to load (so that
we get the same width space).

When the -moz-bullet-font is used we also set 'font-synthesis' to
avoid synthesizing italic/bold for this font. Authors may override
this with an explicit ::marker declaration.

We also set 'letter-spacing' and 'word-spacing' to the initial value
for bullets for web-compat reasons. Again, authors may override
this with an explicit ::marker declaration. (This breaks backwards-
compat slightly but makes us compatible with Chrome. We used to
ignore these for list-style-type:<string> too.)

Depends on D111692

Comment 6

[Mats Palmgren (inactive)]

Attachment: Bug 1542807 part 4 - Exclude fonts loaded from User and UserAgent origin sheets from 'document.fonts'. r=jfkthame

Per https://github.com/w3c/csswg-drafts/issues/6126 these were
never intended to be included in the first place so this is just
fixing a bug. Note that I'm leaving them in the mRuleFaces array
so that the font loading machinery works the same as before.
I'm just excluding them when queried by document.fonts.

Depends on D111693

Comment 7

[Mats Palmgren (inactive)]

Attachment: Bug 1542807 part 5 - Don't apply CSP rules for the document to fonts loaded from User and UserAgent origin sheets. r=jfkthame

As for document.fonts, I don't think we intentionally meant to apply
CSP to User/UserAgent fonts. The document certainly has no authority
to block those from loading. (We already have a separate principal
for these which is further evidence that this was unintentional
and we can use the same bit (mUseOriginPrincipal) to avoid CSP.)

Depends on D111694

Comment 8

[Mats Palmgren (inactive)]

Attachment: Bug 1542807 part 6 - Update test expectations and fix tests that unintentionally depend on bullet ::marker font metrics. r=emilio

Depends on D111695

Comment 9

[Mats Palmgren (inactive)]

Attachment: list-style-image default size test

Comment 10

[Mats Palmgren (inactive)]

Attachment: Bug 1542807 part 7 - Update a11y tests. r=Jamie

Depends on D111696

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eee949e5fd67
part 1 - Create generated content and use normal box construction for list-style-type/list-style-image ::markers.  r=emilio
https://hg.mozilla.org/integration/autoland/rev/cf91e7d0a37f
part 2 - Remove (now unused) nsBulletFrame.  r=emilio
https://hg.mozilla.org/integration/autoland/rev/a71056d4c7cc
part 3 - Add some style quirks for legacy ::markers created from list-style-type/list-style-image.  r=emilio
https://hg.mozilla.org/integration/autoland/rev/e3aee052c495
part 4 - Exclude fonts loaded from User and UserAgent origin sheets from 'document.fonts'.  r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/38daf64afe59
part 5 - Don't apply CSP rules for the document to fonts loaded from User and UserAgent origin sheets.  r=ckerschb
https://hg.mozilla.org/integration/autoland/rev/8fa0cb199975
part 6 - Update test expectations and fix tests that unintentionally depend on bullet ::marker font metrics.  r=emilio
https://hg.mozilla.org/integration/autoland/rev/e9ef32fa2f2e
part 7 - Update a11y tests.  r=eeejay

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/29347 for changes under testing/web-platform/tests

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 14

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e46a708ea73
Backed out 7 changesets for causing failures at inert-retargeting-iframe.tentative.html. CLOSED TREE

Comment 15

[Mats Palmgren (inactive)]

Sigh, inert-retargeting-iframe.tentative.html is just a poorly written test... Filed bug 1716171.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82bc8b9b8bb8
part 1 - Create generated content and use normal box construction for list-style-type/list-style-image ::markers.  r=emilio
https://hg.mozilla.org/integration/autoland/rev/1efb6391d712
part 2 - Remove (now unused) nsBulletFrame.  r=emilio
https://hg.mozilla.org/integration/autoland/rev/9ab332d94fbb
part 3 - Add some style quirks for legacy ::markers created from list-style-type/list-style-image.  r=emilio
https://hg.mozilla.org/integration/autoland/rev/fc9009240a43
part 4 - Exclude fonts loaded from User and UserAgent origin sheets from 'document.fonts'.  r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/5c912a806605
part 5 - Don't apply CSP rules for the document to fonts loaded from User and UserAgent origin sheets.  r=ckerschb
https://hg.mozilla.org/integration/autoland/rev/04385f050f0e
part 6 - Update test expectations and fix tests that unintentionally depend on bullet ::marker font metrics.  r=emilio
https://hg.mozilla.org/integration/autoland/rev/47b4452c0a60
part 7 - Update a11y tests.  r=eeejay

Comment 17

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/82bc8b9b8bb8
https://hg.mozilla.org/mozilla-central/rev/1efb6391d712
https://hg.mozilla.org/mozilla-central/rev/9ab332d94fbb
https://hg.mozilla.org/mozilla-central/rev/fc9009240a43
https://hg.mozilla.org/mozilla-central/rev/5c912a806605
https://hg.mozilla.org/mozilla-central/rev/04385f050f0e
https://hg.mozilla.org/mozilla-central/rev/47b4452c0a60

Comment 18

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by jgraham