Closed Bug 1715895 Opened 2 months ago Closed 2 months ago

Disable sw-wr on non-x86 Linux in late beta and release.

Categories

(Core :: Graphics: WebRender, defect)

defect

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox89 --- fixed
firefox90 --- fixed
firefox91 --- fixed

People

(Reporter: jrmuizel, Assigned: jrmuizel)

References

(Blocks 1 open bug, Regressed 1 open bug)

Details

Attachments

(2 files)

This avoids bug 1714064 (SPARC) and bug 1714511 (ARM)

Blocks: 1714511
Blocks: 1714064

Comment on attachment 9226414 [details]
Bug 1715895 - Disable sw-wr on non-x86 Linux in late beta and release.

Beta/Release Uplift Approval Request

  • User impact if declined: Crashes on SPARC and video corruption on ARM Linux
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This just disables sw-wr on 89 (switches back to the same as 88) on non-x86, it has no impact on builds that we ship.
  • String changes made/needed:
Attachment #9226414 - Flags: approval-mozilla-release?
Attachment #9226414 - Flags: approval-mozilla-beta?
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6d9f9d90a767
Disable sw-wr on non-x86 Linux in late beta and release. r=aosmond
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch

Jeff, I am assuming that this would fix bug 1714511, correct?
I saw that the uplift request in bug 1714069 was removed today, would that also be fixed with this one?

Flags: needinfo?(jmuizelaar)

Nope, this won't help with bug 1714069. We're hoping to use bug 1715902 for that instead.

Flags: needinfo?(jmuizelaar)

Comment on attachment 9226414 [details]
Bug 1715895 - Disable sw-wr on non-x86 Linux in late beta and release.

Approved for beta and release, thanks.

Attachment #9226414 - Flags: approval-mozilla-release?
Attachment #9226414 - Flags: approval-mozilla-release+
Attachment #9226414 - Flags: approval-mozilla-beta?
Attachment #9226414 - Flags: approval-mozilla-beta+

Jeff, this patch does not graft cleanly to release, could you provide a rebased patch please? Thanks

Flags: needinfo?(jmuizelaar)
Flags: needinfo?(jmuizelaar)

I'm confused. There is EARLY_BETA_OR_EARLIER in:

https://hg.mozilla.org/mozilla-central/rev/6d9f9d90a767f4dd696b5648e5ebb0956108e3d4

which can be valid also on SPARC and thus it causes problem again...

But original fix pointed in https://bugzilla.mozilla.org/show_bug.cgi?id=1715895#c11 was missing EARLY_BETA_OR_EARLIER.

Flags: needinfo?(jmuizelaar)

Indeed. sw-wr is disabled in release but it is just temporary to give non-x86 platforms a chance to get their bugs sorted out. The #ifdef will likely be going away in Firefox 91 or 92.

Flags: needinfo?(jmuizelaar)

I would prefer to remove the #ifdef in Firefox 92 (after ESR version)...

You need to log in before you can comment on or make changes to this bug.