Closed Bug 1715965 Opened 6 months ago Closed 4 months ago

ExtensionSettings "normal_installed" local file system extensions don't stay disabled

Categories

(Firefox :: Enterprise Policies, defect, P2)

Firefox 89
defect

Tracking

()

RESOLVED FIXED
92 Branch
Tracking Status
firefox-esr91 --- fixed
firefox92 --- fixed

People

(Reporter: brett.abram, Assigned: mkaply)

Details

Attachments

(3 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:89.0) Gecko/20100101 Firefox/89.0

Steps to reproduce:

  1. Download an extension .xpi to test with. I got the latest uBlock Origin .xpi by navigating to https://addons.mozilla.org/firefox/downloads/latest/ublock-origin/latest.xpi in Edge
  2. Use the ExtensionSettings policy to install the .xpi. I'm on Windows and used regedit to set the Computer\HKEY_LOCAL_MACHINE\SOFTWARE\Policies\Mozilla\Firefox\ExtensionSettings registry string value to "{"uBlock0@raymondhill.net":{"installation_mode":"normal_installed","install_url":"file:///C:/Downloads/ublock_origin-1.35.2-an+fx.xpi"}}"
  3. Open Firefox and see that the extension has been installed
  4. Disable the extension using the switch on about:addons
  5. Restart Firefox

Actual results:

The extension is re-enabled after the restart

Expected results:

The extension should stay disabled

The Bugbug bot thinks this bug should belong to the 'Firefox::Enterprise Policies' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: Untriaged → Enterprise Policies
Attached image regedit.JPG

Hi there,
Is this issue similar to https://bugzilla.mozilla.org/show_bug.cgi?id=1600122 ? Can you explain step 2 a bit further please? I cannot seem to find Computer\HKEY_LOCAL_MACHINE\SOFTWARE\Policies\Mozilla\Firefox\ExtensionSettings (please see my screenshot)

Could you please answer the following questions in order to further investigate this issue?

1- Does this issue happen with a new profile? Here is a link on how to create a new profile: https://support.mozilla.org/en-US/kb/profile-manager-create-remove-switch-firefox-profiles
2- Does this issue occur in the latest nightly version of firefox? Here is a link from where you can download it: https://www.mozilla.org/en-US/firefox/channel/desktop/

Thanks for the report.
Best regards, Clara

Flags: needinfo?(brett.abram)

Hi Clara,

Sorry for being unclear in step 2. If some of the keys don't exist then you need to create them. Right click on "Policies" on the left hand side of regedit and select "New" > "Key" to create the "Mozilla" key. Next create the "Firefox" key in the same way. Then right click the "Firefox" key and select "New" > "String Value" with name "ExtensionSettings" and data:

{"uBlock0@raymondhill.net":{"installation_mode":"normal_installed","install_url":"file:///C:/Downloads/ublock_origin-1.35.2-an+fx.xpi"}}

Replacing file:///C:/Downloads/ublock_origin-1.35.2-an+fx.xpi with the correct path for your computer.

In answer to your questions, the bug still happens when I tried a new profile and Nightly.

Flags: needinfo?(brett.abram)
Attached image example_policy.png

Here's a screenshot of my regedit when I reproduced the bug

I can confirm this.

I think it's related to some new code I added that allows local file addons to be updated.

Assignee: nobody → mozilla
Severity: -- → S2
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Priority: -- → P2

The extension shouldn't have reinstalled at all. We should have detected that it was the same version and not done anything.

That's this first patch.

Next I'm investigating that upgrading keeps it disabled.

Actually, this is the only patch. I've verified that when upgrading, it stays disabled.

Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/e3e4ce3c1020
Handle errors for local XPIs installed by policy. r=mixedpuppy

Backed out for causing xpcshell failures on test_addon_update.js.

Push with failures

Failure log

Backout link

Flags: needinfo?(mozilla)

Patch discovered a bug in another test :).

Flags: needinfo?(mozilla)
Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/e97b9ae43911
Handle errors for local XPIs installed by policy. r=mixedpuppy
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch

Comment on attachment 9232907 [details]
Bug 1715965 - Handle errors for local XPIs installed by policy. r?mixedpuppy!

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Policy only change for sync with 92
  • User impact if declined: Local file XPIs get enabled when they shouldn't.
  • Fix Landed on Version: 92
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Policy only, has tests.
  • String or UUID changes made by this patch:
Attachment #9232907 - Flags: approval-mozilla-esr91?

Comment on attachment 9232907 [details]
Bug 1715965 - Handle errors for local XPIs installed by policy. r?mixedpuppy!

Approved for 91.1esr.

Attachment #9232907 - Flags: approval-mozilla-esr91? → approval-mozilla-esr91+
You need to log in before you can comment on or make changes to this bug.