Closed Bug 1716159 Opened 2 months ago Closed 2 months ago

[tb perma] Intermittent toolkit/components/extensions/test/xpcshell/webidl-api/test_ext_webidl_api_event_callback.js, test_ext_webidl_api.js, test_ext_webidl_runtime_port.js | xpcshell return code: 0

Categories

(Thunderbird :: Upstream Synchronization, defect, P5)

Tracking

(thunderbird_esr78 unaffected)

RESOLVED FIXED
91 Branch
Tracking Status
thunderbird_esr78 --- unaffected

People

(Reporter: intermittent-bug-filer, Assigned: mkmelin)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Those were added in bug 1682632 so from that.
I see https://hg.mozilla.org/mozilla-central/rev/3e47d00b7822fd63eb72e8e0e5e26863214644ea#l8.27 so might just be that our tests are slow enough to timeout.

See Also: → 1682632
Summary: Intermittent toolkit/components/extensions/test/xpcshell/webidl-api/test_ext_webidl_api_event_callback.js, test_ext_webidl_api.js, test_ext_webidl_runtime_port.js | xpcshell return code: 0 → [tb perma] Intermittent toolkit/components/extensions/test/xpcshell/webidl-api/test_ext_webidl_api_event_callback.js, test_ext_webidl_api.js, test_ext_webidl_runtime_port.js | xpcshell return code: 0

(In reply to Magnus Melin [:mkmelin] from comment #2)

Those were added in bug 1682632 so from that.
I see https://hg.mozilla.org/mozilla-central/rev/3e47d00b7822fd63eb72e8e0e5e26863214644ea#l8.27 so might just be that our tests are slow enough to timeout.

Hi Magnus,
in the failure logs I did notice the following error message:

Unexpected exception TypeError: can't access property "ready", content.navigator.serviceWorker is undefined

That looks definitely like a reason for a permafailure, are service workers completely disabled in Thunderbird? (e.g. through setting "dom.serviceWorkers.enabled"` to false in the Thunderbird default prefs).

These bindings are currently experimental, they are part of the work for supporting "manifest_version 3" extensions and the work is still in progress. In the long run it would be good to also make sure that Thunderbird is going to be able to support "manifest_version 3" extensions, but in the short run it may be ok to skip this tests in Thunderbird builds and file a follow up to take a deeper look later on.

Another options could be to enable the service workers in thunderbird only as part of this xpcshell tests.

Flags: needinfo?(mkmelin+mozilla)

Thanks! I had some time to test it now. We just need to enable the pref, and then things work.

Flags: needinfo?(mkmelin+mozilla)
Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/614c9066f7ff
set dom.serviceWorkers.enabled true to fix toolkit/components/extensions/test/xpcshell/webidl-api/ test failures. r=darktrojan

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.