1716397 - Double-click on various links fails to trigger link properties. For many basic cases, no in-place way of editing or checking link location with mouse

Status: NEW

(Thunderbird :: Message Compose Window, defect, P2)

Description

[Thomas D. (:thomas8)]

Attachment: Testcase1: Test message for double-click on links.eml

Editing a link with link text in composition is seriously broken for mouse users in 90.0b1 (32-Bit), Windows 10, and also half-broken for links whose text is an URL. It's now a gambling game if double-click on certain parts of the link succeeds to trigger link properties or not. Editing one-word links like here or this is now impossible with mouse. As a workaround, editing the link via Insert > Link (pretty counter-intuitive) or Ctrl+K works.

STR

1. Open attached testcase
2. Edit as New
3. Double-click on every part or word of every link:

• first and last word of text links
• protocol, domain, and TLD of links whose text is an URL

Alternative plain vanilla DIY STR

• compose with 90.0b1
• Type Try this link (just exactly that) into msg body.
• With text cursor still after k|, hold Shift while pressing cursor-left to select this link (just that).
• Press Ctrl+K, add link location, OK.
• Now double click on any part of this link.

Actual result

• Double-click fails to trigger Link Properties dialog at every other corner of most links.
• With links whose text is just words it's worse, URL linktext works better (in the middle), but mostly not for double-click on protocol or TLD.
• Go figure the details from the test case, make sure to click left/right/centre on each link.

Expected result

• Double-click on any part of the Link should select exactly the full link text and trigger the Link Properties dialog

I'm aware that this is editor territory, but I consider this as serious enough that we should strive to push for a fast solution from our side.

Comment 1

[Thomas D. (:thomas8)]

This is also compounded by the fact that in 2021, we still don't have an "Edit Link" context menu item.

Comment 2

[Thomas D. (:thomas8)]

Attachment: Screencast of testing Testcase 1 on TB 90.0b1: LinkDoubleClickFail.mp4

Here's a screencast of testing testcase attachment 9226917 [details] on TB 90.0b1 (32bit) on Windows 10.
Every double click on some part of a link where the Link Properties window does not pop up is a fail.

Comment 3

[Magnus Melin [:mkmelin]]

Probably something going wrong when we find what element to edit: https://searchfox.org/comm-central/rev/d022f03b903e5de8602dff4dfbb6853a696777d5/mail/components/compose/content/editor.js#1307

Comment 4

[Thomas D. (:thomas8)]

Bug 1572648 (Embed rich link previews) is also working on links in composition.

Comment 5

[Thomas D. (:thomas8)]

Sorry, I meant bug 1572648 which is also working on links in composition (correction of comment 4).

Comment 6

[Ryan Lee Sipes]

This is a legit link bug. Magnus, since you are in link land currently - you want to take a glance and see if you can find a fix for this?

Comment 7

[Thomas D. (:thomas8)]

This is a regression from TB 78 to TB 90.0.
Alice, would you be able to narrow this down?

Comment 8

[Alice0775 White]

Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=45bd9be84c3d9a0c6a9025709ee28bcc2abc2485&tochange=2c583204ea8e29cddc780c7686fae5275a8e9201
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=bf162b065e1feaa64d6df95bc55ee8a894312d34&tochange=e87e4800d332c50a117e8d0a879809db9eb965dc

The regression seems to be caused by Bug 1632425.

Comment 9

[Thomas D. (:thomas8)]

(In reply to Alice0775 White from comment #8)

The regression seems to be caused by Bug 1632425.

Phantastic! Alice, you rock!

Comment 10

[Magnus Melin [:mkmelin]]

It seems to behaving rather inconsistently. Sometimes I do get the properties dialog after all... especially after moving from one link to another.

Having double click select seems to be correct and consistent with what is done elsewhere, like TinyMCE and gmail web ui. The basic problem is per comment 1 - we need a context menu or something similar...