1716403 - Tests skipped in 'dom/animation/test/mochitest.ini' for new fission xorigin platform triage

Status: NEW

(Core :: DOM: Animation, task)

Description

[Andrew Halberstadt [:ahal]]

Note: This bug was filed automatically via script.

The following tests are being disabled in dom/animation/test/mochitest.ini due to new fission xorigin platform triage:

• style/test_missing-keyframe-on-compositor.html
• mozilla/test_pending_animation_tracker.html

Full diff:

diff --git a/dom/animation/test/mochitest.ini b/dom/animation/test/mochitest.ini
--- a/dom/animation/test/mochitest.ini
+++ b/dom/animation/test/mochitest.ini
@@ -46,16 +46,18 @@ skip-if = (os == 'win' && bits == 64) # 
 [mozilla/test_distance_of_filter.html]
 [mozilla/test_distance_of_path_function.html]
 [mozilla/test_distance_of_transform.html]
 [mozilla/test_document_timeline_origin_time_range.html]
 [mozilla/test_hide_and_show.html]
 [mozilla/test_mainthread_synchronization_pref.html]
 [mozilla/test_moz_prefixed_properties.html]
 [mozilla/test_pending_animation_tracker.html]
+skip-if =
+  fission && xorigin && os == "linux" && !debug  # {bug} - New fission platform triage
 [mozilla/test_restyles.html]
 skip-if =
   os == 'win' && !webrender # Bug 1663509
 [mozilla/test_restyling_xhr_doc.html]
 [mozilla/test_set_easing.html]
 [mozilla/test_style_after_finished_on_compositor.html]
 [mozilla/test_transform_limits.html]
 [mozilla/test_transition_finish_on_compositor.html]
@@ -67,9 +69,11 @@ skip-if = (os == "win" && processor == "
 [style/test_animation-seeking-with-current-time.html]
 [style/test_animation-seeking-with-start-time.html]
 [style/test_animation-setting-effect.html]
 [style/test_composite.html]
 skip-if = xorigin 
 [style/test_interpolation-from-interpolatematrix-to-none.html]
 [style/test_missing-keyframe.html]
 [style/test_missing-keyframe-on-compositor.html]
+skip-if =
+  fission && xorigin  # {bug} - New fission platform triage
 [style/test_transform-non-normalizable-rotate3d.html]

See this try push for failures. If failures are missing, they were
either discovered on a subsequent try push or this bug is invalid.

To run these failures in your own try push, first ensure the patches from bug 1700781
have landed, revert the skip-if annotations, then run:

$ ./mach try fuzzy --rebuild 3 dom/animation/test/mochitest.ini

Finally use the fuzzy interface to select the task(s) which are relevant to the
removed skip-if expression(s).

Disclaimer

Adding new platforms is not an exact science, and in order to get to green and
enable coverage ASAP, we often err on the side of disabling when in doubt. For
this reason, it's possible that the annotation was added in error, is covered
by an existing intermittent, or was fixed sometime between now and when the
annotation was made.

If you believe this is the case here, please feel free to remove the
annotation. Sorry for the inconvenience and thanks for understanding.

Comment 1

[Chris Peterson [:cpeterson]]

style/test_missing-keyframe-on-compositor.html

I think this failure is bug 1324405 ("another variant of the case where the animation just begins at the current timeline time"), which used to be seen intermittently in non-Fission code. As such, this failure probably doesn't need to block shipping Fission.

TEST-UNEXPECTED-FAIL | dom/animation/test/style/test_missing-keyframe-on-compositor.html | Initial opacity value for animation with no no keyframe at offset 0 - Initial opacity value for animation with no no keyframe at offset 0: assert_equals: The initial opacity value should be the base value expected "0.1" but got ""

mozilla/test_pending_animation_tracker.html

I think this failure is a false positive. I don't see any test_pending_animation_tracker.html failures in comment 0's tr push or other recent Fission+xorigin try pushes. We can just remove this skip-if annotation.

Given these failures, I don't think this bug needs to block Fission MVP. Setting Fission Milestone to "Future".

Comment 2

[Hiroyuki Ikezoe (:hiro)]

As I commented somewhere, test_missing-keyframe-on-compositor.html should have been fixed by bug 1706853.