1706853 - [M-fis-xorig] High intermittent layout/style/test/test_animations_effect_timing_enddelay.html | OMTA should work

Status: RESOLVED FIXED

(Core :: Layout, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: hikezoe.birchill [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=337395805&repo=try
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/ZbjmqGFSRH-6Em-gJPzQYQ/runs/2/artifacts/public/logs/live_backing.log

---

Comment 1

[Intermittent Failures Robot]

1 failures in 3224 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1

Platform and build breakdown:

• linux1804-64-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1706853&startday=2021-04-19&endday=2021-04-25&tree=all

Comment 2

[Hiroyuki Ikezoe (:hiro)]

I cloud reproduce the failure locally on an opt build. Will try to catch what's going on there.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

So the failure happens when we haven't received BrowserChild::mTopLevelViewportVisibleRectInBrowserCoords from APZ.

Our animation code has an optimization that we skip restyling/painting where the animation's target element is scrolled out. If the target element is in an OOP iframe, we use the BrowserChild::mTopLevelViewportVisibleRectInBrowserCoords to see whether the iframe is scrolled out (or clipped out) by ancestor viewports. But if we haven't received the mTopLevelViewportVisibleRectInBrowserCoords from APZ, the corresponding function, BrowserChild::GetTopLevelViewportVisibleRectInBrowserCoords returns an empty rectangle, thus we incorrectly consider the element is scrolled out, then we fail to paint the animation, thus we fail a sanity check in animation_utils.js.

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1706853 - Make GetFrameVisibleRectOnScreen return Nothing() if we haven't received OOP iframe's transformed rectangle from APZ. r?botond

With this change we no longer incorrectly consider there is no visible rect for
the OOP iframe where we haven't yet received the rectangle from APZ.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e0d86ff0ab9
Make GetFrameVisibleRectOnScreen return Nothing() if we haven't received OOP iframe's transformed rectangle from APZ. r=botond

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/5e0d86ff0ab9