1716410 - Tests skipped in 'layout/style/test/mochitest.ini' for new fission xorigin platform triage

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Description

[Andrew Halberstadt [:ahal]]

Note: This bug was filed automatically via script.

The following tests are being disabled in layout/style/test/mochitest.ini due to new fission xorigin platform triage:

• test_animations_reverse.html
• test_transitions_per_property.html
• test_bug1451199-1.html
• test_animations_effect_timing_iterations.html
• test_animations_iterationstart.html
• test_animations_playbackrate.html
• test_animations_omta_start.html
• test_bug1451199-2.html

Full diff:

diff --git a/layout/style/test/mochitest.ini b/layout/style/test/mochitest.ini
--- a/layout/style/test/mochitest.ini
+++ b/layout/style/test/mochitest.ini
@@ -66,24 +66,34 @@ support-files = additional_sheets_helper
 [test_all_shorthand.html]
 [test_animations.html]
 [test_animations_async_tests.html]
 support-files = Ahem.ttf file_animations_async_tests.html
 [test_animations_dynamic_changes.html]
 [test_animations_effect_timing_duration.html]
 [test_animations_effect_timing_enddelay.html]
 [test_animations_effect_timing_iterations.html]
+skip-if =
+  fission && xorigin && os == "mac" && debug  # {bug} - New fission platform triage
 [test_animations_event_order.html]
 [test_animations_event_handler_attribute.html]
 [test_animations_iterationstart.html]
+skip-if =
+  fission && xorigin && ((os == "mac" && debug) || (os == "linux" && !debug)) # {bug} - New fission platform triage
 [test_animations_omta.html]
 [test_animations_omta_start.html]
+skip-if =
+  fission && xorigin && os == "win" && !debug  # {bug} - New fission platform triage
 [test_animations_pausing.html]
 [test_animations_playbackrate.html]
+skip-if =
+  fission && xorigin && os == "mac" && debug  # {bug} - New fission platform triage
 [test_animations_reverse.html]
+skip-if =
+  fission && xorigin && os == "mac" && debug  # {bug} - New fission platform triage
 [test_animations_styles_on_event.html]
 [test_animations_variable_changes.html]
 [test_animations_with_disabled_properties.html]
 support-files = file_animations_with_disabled_properties.html
 [test_any_dynamic.html]
 [test_area_url_cursor.html]
 [test_asyncopen.html]
 [test_at_rule_parse_serialize.html]
@@ -176,17 +186,21 @@ support-files = bug1382568-iframe.html
 [test_bug1394302.html]
 [test_bug1443344-1.html]
 scheme = https
 support-files = file_bug1443344.css
 [test_bug1443344-2.html]
 scheme = https
 support-files = file_bug1443344.css
 [test_bug1451199-1.html]
+skip-if =
+  fission && xorigin && os == "linux" && !debug  # {bug} - New fission platform triage
 [test_bug1451199-2.html]
+skip-if =
+  fission && xorigin && os == "linux" && !debug  # {bug} - New fission platform triage
 [test_bug1490890.html]
 [test_bug1505254.html]
 [test_cascade.html]
 [test_ch_ex_no_infloops.html]
 [test_change_hint_optimizations.html]
 [test_clip-path_polygon.html]
 [test_color_rounding.html]
 [test_compute_data_with_start_struct.html]
@@ -354,16 +368,18 @@ support-files = file_specified_value_ser
 [test_transitions_cancel_near_end.html]
 [test_transitions_computed_values.html]
 [test_transitions_computed_value_combinations.html]
 [test_transitions_events.html]
 [test_transitions.html]
 [test_transitions_bug537151.html]
 [test_transitions_dynamic_changes.html]
 [test_transitions_per_property.html]
+skip-if =
+  fission && xorigin  # {bug} - New fission platform triage
 [test_transitions_replacement_on_busy_frame.html]
 [test_transitions_replacement_with_setKeyframes.html]
 [test_transitions_step_functions.html]
 [test_unclosed_parentheses.html]
 [test_unicode_range_loading.html]
 support-files = ../../reftests/fonts/markA.woff ../../reftests/fonts/markB.woff ../../reftests/fonts/markC.woff ../../reftests/fonts/markD.woff
 [test_units_angle.html]
 [test_units_frequency.html]

See this try push for failures. If failures are missing, they were
either discovered on a subsequent try push or this bug is invalid.

To run these failures in your own try push, first ensure the patches from bug 1700781
have landed, revert the skip-if annotations, then run:

$ ./mach try fuzzy --rebuild 3 layout/style/test/mochitest.ini

Finally use the fuzzy interface to select the task(s) which are relevant to the
removed skip-if expression(s).

Disclaimer

Adding new platforms is not an exact science, and in order to get to green and
enable coverage ASAP, we often err on the side of disabling when in doubt. For
this reason, it's possible that the annotation was added in error, is covered
by an existing intermittent, or was fixed sometime between now and when the
annotation was made.

If you believe this is the case here, please feel free to remove the
annotation. Sorry for the inconvenience and thanks for understanding.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

(In reply to Andrew Halberstadt [:ahal] from comment #0)

Note: This bug was filed automatically via script.

The following tests are being disabled in layout/style/test/mochitest.ini due to new fission xorigin platform triage:

• test_animations_reverse.html
• test_animations_effect_timing_iterations.html
• test_animations_iterationstart.html
• test_animations_playbackrate.html
• test_animations_omta_start.html

These should have already been fixed by bug 1706853, the fixed landed June 9 (in JST), the try run was pushed before the land.

• test_transitions_per_property.html

This is probably due to bug 1662625 comment 28.

• test_bug1451199-2.html
• test_bug1451199-1.html

I haven't looked at these.

Comment 2

[Andrew Halberstadt [:ahal]]

I removed the test_animations_* annotations prior to landing. Thanks for pointing this out!

Comment 3

[Chris Peterson [:cpeterson]]

(In reply to Andrew Halberstadt [:ahal] from comment #2)

I removed the test_animations_* annotations prior to landing. Thanks for pointing this out!

That leaves the remaining skip-if annotations to be fixed and removed for this bug:

test_transitions_per_property.html
test_bug1451199-1.html
test_bug1451199-2.html

Comment 4

[Neha Kochar [:neha]]

Frank, this needs your team's attention to figure out if these failures are still happening and if yes, then fix them.

Comment 5

[Frank Griffith Jr]

Will ask [e-mail] to take a look at those last tests after Bug 1713547

Comment 6

[Chris Peterson [:cpeterson]]

Tracking for Fission Milestone M8.

Since all of these skipped tests (expect test_transitions_per_property.html) are skipped for only one operating system, they are probably test race conditions and not Fission bugs. test_transitions_per_property.html is skipped for all platforms with fission && xorigin, which might indicate a real (code or test) bug related to xorigin test mode.

Comment 7

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1716410 - Regenerate the target element for OMTA tests. r?boris

nsIDOMWindowUtils.getOMTAStyle is for querying an in-progress animating value
running on the compositor thread. The key to query the value is stored in the
target nsIFrame of the animating element, and the key is basically based on
the display item (type) in question, DisplayItemType::TYPE_TRANSFORM in cases of
transform animations, etc. etc. So if getOMTAStyle gets called for an element
where
a) an animation is running on the compositor
b) a new animation is just created

then, it's possible that getOMTAStyle queries a)'s animation value instead of
b)'s.

Comment 8

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1716410 - Add a comment to nsIDOMWindowUtils.getOMTAStyle to avoid being used for elements which had another animation. r?boris

Depends on D119127

Comment 9

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1716410 - Enable test_bug1451199-1.html and test_bug1451199-2.html on fis-xorig. r?emilio

The failure cause was fixed in bug 1717983.

Comment 10

[Hiroyuki Ikezoe (:hiro)]

I am holding on landing D119130 since bug 1717983 might be back-ed out.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b8b0a777c08
Regenerate the target element for OMTA tests. r=boris
https://hg.mozilla.org/integration/autoland/rev/a2e6beb5031b
Add a comment to nsIDOMWindowUtils.getOMTAStyle to avoid being used for elements which had another animation. r=boris

Comment 12

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/4b8b0a777c08
https://hg.mozilla.org/mozilla-central/rev/a2e6beb5031b

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5bb4dbadd992
Enable test_bug1451199-1.html and test_bug1451199-2.html on fis-xorig. r=emilio

Comment 14

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/5bb4dbadd992