1716705 - [Downloads tab] The downloads box isn't scrollable when too many elements are in it

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Richard Marti (:Paenglab)]

The downloads box isn't scrollable when too many elements are in it

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1716705-aboutDownloads-scrollable.patch

It doesn't work because it is in a stack. I removed this stack. FX doesn't show also no message when no download is in it.

I also updated the test to work with the removed msgDownloadsListEmptyDescription: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=7a45cda774d6dcc2f55e7ebdd4c039bc43bf25a9

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9227332 [details] [diff] [review]
1716705-aboutDownloads-scrollable.patch

Review of attachment 9227332 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! r=mkmelin

::: mail/test/browser/downloads/browser_aboutDownloads.js
@@ +333,5 @@
>      "Timeout waiting for clearing all saved attachment files."
>    );
>  
> +  let list = content_tab_e(downloadsTab, "msgDownloadsRichListBox");
> +  Assert.ok(!list.children.length, "Download list is not empty");

Could be clearer if it ever starts failing to have it as

Assert.equal(list.children.length, 0, "Downloads list should be empty");

(same above)

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1716705-aboutDownloads-scrollable.patch

Addressed the review comment.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e5a72b98ffde
Make the downloads box scrollable when overflowing. r=mkmelin