1716731 - Update Yandex favicons and tippytop icons

Status: VERIFIED FIXED

(Firefox :: Search, task, P1)

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1716731 - Update Yandex favicons and tippytop icons. r=Standard8

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a4d03a34c4bb
Update Yandex favicons and tippytop icons. r=Standard8

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 9227348 [details]
Bug 1716731 - Update Yandex favicons and tippytop icons. r=Standard8

Beta/Release Uplift Approval Request

• User impact if declined: Yandex asked us to do this so users aren't presented with their old icon
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: aflorinescu is working on verifying this
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a pretty ordinary image dump
• String changes made/needed:

Comment 4

[Adrian Florinescu [:aflorinescu]]

For the time being I've verified the search-engines and topsites icons for a set of try-builds (en-US - 91 Nightly, 90 Beta and 89 Release) with RU region on Windows 10:

release: https://treeherder.mozilla.org/#/jobs?repo=try&revision=37715b83293e9f32b559f32d7c6cbccdddc37932
beta: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a9ef057a0cdfe1370f9c83aff2823d82062a19d1
m-c: https://treeherder.mozilla.org/jobs?repo=try&revision=45d6005430ebd0308417a14992684dc173f8183e

What's left here to do is to verify the other regions affected by the direct link rollout: TR, KZ, BY with their default locales + Ubuntu and Mac spot check.

Comment 5

[(No longer employed by Mozilla) Aaron Klotz]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=327fe77552153e98d99a8793b7e103f7c8878cd0

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/a4d03a34c4bb

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 9227348 [details]
Bug 1716731 - Update Yandex favicons and tippytop icons. r=Standard8

approved for 90.0b9

Comment 8

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/57b482b0834d

Comment 9

[Adrian Florinescu [:aflorinescu]]

Verification completed using Nightly 91.0a1 2021-06-17 and Beta 90.0b9 on Windows 10, Mac 11.3 and Ubuntu 20.04.

Verification consisted into checking the favicon icon change for the address bar and search options and the tippy-top icons for topsites across a spot-checked combination of the 4 target regions on which a variation of yandex is default - RU, KZ, BY and TR with locales including en-US, en-GB and the native locales (KK, BE, TR, RU) for the above regions.

Comment 10

[Pascal Chevrel:pascalc (PTO until April 26)]

I am marking 89 as affected in case we have another dot release we could take this one in.

Comment 11

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9227348 [details]
Bug 1716731 - Update Yandex favicons and tippytop icons. r=Standard8

I am going to take this patch in 89.0.2

Comment 12

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-release/rev/9fcea995d1da

Comment 13

[Adrian Florinescu [:aflorinescu]]

Verficaition of yandex icons update done and looking good on 89 RC2 @ 89.0.2 2021-06-22 with the following locale/region coverage:

en-US/RU - Windows 10
kk/KZ, kk/RU - Mac 11
en-CA/RU, kk/ TR - Ubuntu 20

The above verification was done using production Remote Settings configuration (yandex rollout live) + manually added region (no VPN) and manually set rollout preference ( user_pref("browser.topsites.experiment.yandex-2021-1", true); )