1716763 - Filter Rules list doesn't fit in filter window. size too large for screen

Status: RESOLVED DUPLICATE of bug 1365521

(Thunderbird :: Filters, defect)

Description

[Christopher M. Penalver]

Attachment: Thunderbird Filter Rules Window.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

Tools > Message Filters > in Message Filters windows select filter > Edit...

Actual results:

When the Filter Rules window opens, it's too big vertically at the bottom for the screen to display the entire window. Hence, at the bottom the OK and Cancel buttons are not visible, and not immediately selectable. This is annoying for those like myself who have to make frequent updates to filters.

Expected results:

The Filter Rules window opens within the size of the screen display, so that the OK and Cancel buttons are visible.

Comment 1

[WaltS48 [:walts48]]

Dragging the top window border down until I saw the buttons worked for me using 78.11.0 on a Windows 10 Dell Laptop.

Comment 2

[Anje]

It sounds like the window was extended at some point to see info and then closed so that new extended window size was remembered and it now opens using it.
But if you follow WaltS48 advice in comment 1 and then close window, it should reopen in the last state when closed. We would need to know if that occurs.

Comment 3

[Christopher M. Penalver]

Hi Anji:

1. The window was not extended at any point, closed, and then remembered.
2. Following comment 1 did not reopen it in the last state when closed.

Comment 4

[Anje]

Please try the following:
In Thunderbird
Menu app icon > Help > Troubleshooting Information
Under 'Application Basics' - about 8th in list 'Profiles Folder' - click on 'Open folder'
A new window opens showing the contents of your 'profile name' folder.
Exit Thunderbird now.
Delete the following files:
session.json
xulstore.json

Start Thunderbird
Test opening of message filter.
Please report on results.

Comment 5

[Christopher M. Penalver]

Hi Anje, I did precisely what you noted, and while I noticed some changes to the GUI, when I opened the Filter Rules window it opened the same as the provided screenshot (i.e. no change).

Comment 6

[WaltS48 [:walts48]]

(In reply to Christopher M. Penalver from comment #5)

Hi Anje, I did precisely what you noted, and while I noticed some changes to the GUI, when I opened the Filter Rules window it opened the same as the provided screenshot (i.e. no change).

You still can't resize the dialog window by grabbing the top and dragging it down until the button appears, or right-click in the dialog titlebar and select "Size" from the context menu and resize the window?

You might need to drag the top border down, then move the dialog window up and repeat a few times until you see the buttons depending on how many filters you have.

Comment 7

[Anje]

The issue looks like the bottom of the window is below the Task Bar.
Hence you would need to reduce the height of window from the top first and then drag window up, so the bottom of Filter Rules window is now above the bottom Task Bar.
I am assuming you are able to do this.
Can you confirm you can do that so window now appears correct?

I am also assuming you only have this issue when opening that particular Filter and this does not occur on other filters that only have a couple of conditions or in a new filter rules window.
Does it occur in a new Filter Rules window before you have entered anything?

In that particular filter you seem to have a lot of 'From' entries which when matched do a particular action.
It looks like if any emails get downloaded and match email address then send to TRash.
I would have thought you could just use Junk controls to send them to Junk and then put an auto Empty on the Junk folder.
But you are doing it this way via filter.

How many 'FROM' entries are there as I'm trying to reproduce the issue?
What size screen do you use ?
What dpi screen resolution ?

Comment 8

[Christopher M. Penalver]

Hi, taskbar placement isn't relevant here as my taskbar is actually on the left side of the screen (not below the window). However, taskbar being at the bottom doesn't change anything.

Regarding your questions:
How many 'FROM' entries are there as I'm trying to reproduce the issue?
30+.

What size screen do you use ?
As per tech specs:
https://www.lenovo.com/us/en/laptops/thinkpad/thinkpad-p/ThinkPad-P52s/p/22TP2WPP52S
15.6" FHD (1920 x 1080) WVA, anti-glare, 250 nits

What dpi screen resolution ?
Resolution 3840x2160

Thanks!

Comment 9

[Anje]

Findings to help sort out this problem and what is occuring so developers understand what is going on.

The 'Filter Rules' window increases in height as more conditions are added.
Initially, the height remains the same and a scrollbar appears.
After saving, closing and opening again as edit, the scrollbar is removed and the height of the window increases.
When there are 17 conditions, the window height is almost at max setting, there is no scrollbar.
When there are 18 conditions, the window reaches an auto max height best guess 945 and the scrollbar is shown.
More than 18 conditions does not increase the window height any further.

Important note:
Whilst you can drag the height of the Filter Rules window to a more suitable size, after clicking on ok to close and then opening as edit again, that window size is not remembered and it reopens on max size again. Each filter rule will have it's own window height determined by the number of conditions. eg: From contains xyz

Conclusion:
the 'Filter rules' window size is not remembered as a generic window size for Filter Rules edit window.
It's height is determined by the number of conditions, so different filter rules with less conditions will open using less height.

In xulstore, the window size of the 'Message Filters' window is remembered.
example showing default size first and also after altering 'Message Filters' window height.
Message Filter window:
"chrome://messenger/content/FilterListDialog.xhtml":{"filterListDialog":{"screenX":"1334","screenY":"25","width":"556","height":"520"}}
"chrome://messenger/content/FilterListDialog.xhtml":{"filterListDialog":{"screenX":"1334","screenY":"25","width":"556","height":"943"}}

note: I dragged the 'Message Filters' window down to be same height as the 'edit' 'Filter Rules' window, hence how I can guess max height is set at approx 945.

This is not a real problem on a larger screen. I use a 27 inch screen resolution 1920 x 1080, so I can still see every ok. It does use most of the height available on my screen. But on a smaller screen size this may force the window height beyond the actual viewable height and require manual resize on each opening which is not desireable.

I would agree that this is a bug which people can experience if they are using a smaller screen eg: 15.6 inch.

Additional Information:
This is not a problem in version 68.12.0
The Filter rules window size is remembered.
It does not auto increase in height - it uses the scrollbar as expected when additional conditions are created.
I can choose the height, ok to close and reopen on same size of window.
The number of conditions does not have any effect in this respect.