Closed
Bug 1716842
Opened 3 years ago
Closed 3 years ago
X11-only build failures caused by the patch in bug 1661516
Categories
(Core :: Widget: Gtk, defect, P3)
Core
Widget: Gtk
Tracking
()
RESOLVED
FIXED
91 Branch
Tracking | Status | |
---|---|---|
firefox91 | --- | fixed |
People
(Reporter: twisniewski, Assigned: twisniewski)
References
Details
Attachments
(1 file, 1 obsolete file)
In https://phabricator.services.mozilla.com/D117283, three #ifdef MOZ_WAYLAND
were removed from widget/gtk/nsWindow.cpp. This is causing build failures on X11-only builds, as the functions those sections rely on are only defined for MOZ_WAYLAND.
Assignee | ||
Comment 1•3 years ago
|
||
Here's a patch that let me complete my X11 build.
Assignee: nobody → twisniewski
Assignee | ||
Updated•3 years ago
|
Assignee: twisniewski → nobody
Comment 2•3 years ago
|
||
Do you mind to post it by phabricator please?
Thanks.
Flags: needinfo?(twisniewski)
Updated•3 years ago
|
Priority: -- → P3
Assignee | ||
Comment 3•3 years ago
|
||
Comment on attachment 9227477 [details] [diff] [review]
1716842.diff
Ok, I'll do so.
Attachment #9227477 -
Attachment is obsolete: true
Assignee | ||
Comment 4•3 years ago
|
||
Updated•3 years ago
|
Assignee: nobody → twisniewski
Status: NEW → ASSIGNED
Comment 5•3 years ago
|
||
build of m-c on OpenBSD (which wont have wayland for now) failed, https://bugzilla.mozilla.org/attachment.cgi?id=9227561 fixes the build for me, thanks !
shouldnt this have been catched by automation ? Or i guess the ship has sailed and there are no X11-only configurations in the bazillions of jobs ran on each commit ?
Pushed by stransky@redhat.com:
https://hg.mozilla.org/integration/autoland/rev/4f5f1a1d0636
add back some MOZ_WAYLAND ifdefs which were removed in D117283 so that X11-only builds continue to work; r=stransky
Comment 7•3 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox91:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
Assignee | ||
Updated•3 years ago
|
Flags: needinfo?(twisniewski)
You need to log in
before you can comment on or make changes to this bug.
Description
•