1716842 - X11-only build failures caused by the patch in bug 1661516

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Thomas Wisniewski [:twisniewski]]

In https://phabricator.services.mozilla.com/D117283, three #ifdef MOZ_WAYLAND were removed from widget/gtk/nsWindow.cpp. This is causing build failures on X11-only builds, as the functions those sections rely on are only defined for MOZ_WAYLAND.

Comment 1

[Thomas Wisniewski [:twisniewski]]

Attachment: 1716842.diff

Here's a patch that let me complete my X11 build.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Do you mind to post it by phabricator please?
Thanks.

Comment 3

[Thomas Wisniewski [:twisniewski]]

Comment on attachment 9227477 [details] [diff] [review]
1716842.diff

Ok, I'll do so.

Comment 4

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1716842 - add back some MOZ_WAYLAND ifdefs which were removed in D117283 so that X11-only builds continue to work; r?stransky

Comment 5

[Landry Breuil (:gaston)]

build of m-c on OpenBSD (which wont have wayland for now) failed, https://bugzilla.mozilla.org/attachment.cgi?id=9227561 fixes the build for me, thanks !

shouldnt this have been catched by automation ? Or i guess the ship has sailed and there are no X11-only configurations in the bazillions of jobs ran on each commit ?

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f5f1a1d0636
add back some MOZ_WAYLAND ifdefs which were removed in D117283 so that X11-only builds continue to work; r=stransky

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/4f5f1a1d0636