1661516 - [Wayland] context menu automatically selects last entry on right click

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P1)

Description

[Remi Salmon]

Attachment: Screencast from 08-27-2020 09:43:40 AM.webm

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:80.0) Gecko/20100101 Firefox/80.0

Steps to reproduce:

When right clicking in the bottom right corner of the screen, the last entry of the context menu is automatically selected when releasing the right click.

Happens only under wayland; when using xwayland the context menu shows as expected.

Reproduced with firefox 80.0 and firefox nightly 82.0a1 on Fedora 32.

Actual results:

The screenshot tool show up on right click (see attached video).

Expected results:

The context menu should show up.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Jonas Ådahl]

Looks like the xdg_positioner is setup to open the menu in a way that the menu is only offset correctly to the right and downwards. That means when it is flipped in both x and y directions (because you open it close to the bottom right corner) the last menu element will automatically be selected.

The way to setup the xdg_positioner is to create a 1x1 "anchor rect" corresponding to the click position, and setup the anchors and gravity so that it opens downwards to the right, with the flip y and flip x hints set so that the anchor and gravity are flipped, i.e. the menu is opened upwards/leftwards outside of the same 1x1 rect.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Jan, any idea here?

Comment 4

[Remi Salmon]

A workaround/fix could be to disable right click actions on the context menu itself maybe?

Right now right clicking on an entry of the context menu activates that entry (not useful/necessary and triggers this bug).
Looking at the main "hamburger" menu, right clicking on an entry does nothing (as expected).

Comment 5

[Jan Horak [:jhorak]]

Attachment: Bug 1661516 Use right gravity for the context menu to flip it correctly; r=stransky

To flip context menu correctly near the monitor edge we need to use
correct gravity and anchor of 2x2 size for the gdk_window_move_to_rect.

Comment 6

[Jan Horak [:jhorak]]

The fix does not deal with the font scaling != 1. (ie. 1.25, or 1.5) when rounding errors happens and the popup is repositioned due to this. Followup bug 1708709.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eecb6331a2c1
Use right gravity for the context menu to flip it correctly; r=stransky

Comment 8

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/eecb6331a2c1

Comment 9

[rpigott]

I think bug 1701877 is a dupe.

Comment 10

[Martin Stránský [:stransky] (ni? me)]

Please backout this bug. It causes popup regressions and we need to think about it.

Comment 11

[Iulian Moraru]

Backed out for causing popup regressions.

Backout link

Comment 12

[eoli3n]

The bug is not just is which direction the menu draw but also that right clic randomly opens a "dynamic menu".

The menu closes if you release right clic.
If you keep right clic clicked and move the mouse on the menu entry you want, releasing right clic select that entry.
Sometimes, a static menu is open as expected, releasing right clic keep the menu open and you can select what you want.

Comment 13

[Martin Stránský [:stransky] (ni? me)]

Let's fix that when Bug 1710436 lands.

Comment 14

[Martin Stránský [:stransky] (ni? me)]

Can you please test latest nightly under Wayland? A new popup handling code landed there.
Thanks.

Comment 15

[Remi Salmon]

(In reply to Martin Stránský [:stransky] (ni? me) from comment #14)

Can you please test latest nightly under Wayland? A new popup handling code landed there.
Thanks.

This issue is still present under Wayland in nightly 91.0a1 (2021-06-04) (64-bit).

Comment 16

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1661516 [Wayland] Don't use context menu shift in nsMenuPopupFrame::SetPopupPosition(), r?jhorak

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27149a6f3ca9
[Wayland] Don't use context menu shift in nsMenuPopupFrame::SetPopupPosition(), r=jhorak

Comment 19

[Atila Butkovits]

Backed out for causing build bustages on nsMenuPopupFrame.cpp.

Backout link: https://hg.mozilla.org/integration/autoland/rev/8601975ad8323b5f8ff07920f505f0c02fd2bd55

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=ZDULTcAtThSL603a5xbmbA.0&revision=27149a6f3ca948115fb26a2c5064df11233764ba&searchStr=android-4-0-armv7%2Copt%2Cbuild-android-arm%2Fopt%2Cb

Failure log: https://treeherder.mozilla.org/logviewer?job_id=342713279&repo=autoland&lineNumber=26363

Comment 20

[Martin Stránský [:stransky] (ni? me)]

Updated, thanks. try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=405cc8b05038bd42f7f1747b541742e160a679ad

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b82d177a6b9
[Wayland] Don't use context menu shift in nsMenuPopupFrame::SetPopupPosition(), r=jhorak

Comment 22

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/7b82d177a6b9