1716861 - LDAP address books can't cope with multiple searches from browser.contacts.quickSearch at the same time

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Mark Banner (:standard8)]

In bug 1679364 I added the capability to read from read-only address books via contacts.quickSearch.

In Conversations I have been trying to speed up contacts access. One thing I do is to kick off multiple contacts searches at the same time.

It appears that kicking off multiple searches for LDAP fails to resolve the promises for all the searches.

I think we either need to disable remote searches via quickSearch or fix it. Whilst we could warn add-on authors, I suspect you could get circumstances where two add-ons do a search at the same time (and as LDAP searches can take a second or two, you'd be more likely to hit it).

Comment 1

[Mark Banner (:standard8)]

Adding tracking request, as I think we should come to a resolution on this before 91 ships.

Comment 2

[Ping Chen [:rnons] (away)]

We can only investigate this after bug 1716858.

Comment 3

[Mark Banner (:standard8)]

Just a reminder that the other bug is fixed now.

Comment 4

[Ping Chen [:rnons] (away)]

Attachment: Bug 1716861 - Support concurrent searches in LDAP Directory. r=darktrojan

It was implemented by following nsAbLDAPDirectory.cpp to call stopSearch in search. This patch removes the stopSearch call in search, so that concurrent searches work.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c3b91b49b068
Support concurrent searches in LDAP Directory. r=darktrojan

Comment 6

[Rob Lemley [:rjl]]

Comment on attachment 9230440 [details]
Bug 1716861 - Support concurrent searches in LDAP Directory. r=darktrojan

[Triage Comment]
Goes with other address book bugs that are being uplifted to Thunderbird 91beta.

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 91.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/d1f36168b605