Closed Bug 1716950 Opened 2 years ago Closed 2 years ago

'Add-ons and Themes' button's tooltip is broken/not shown because of wrong attribute name

Categories

(Thunderbird :: General, defect)

defect

Tracking

(thunderbird88 unaffected, thunderbird89 affected, thunderbird90 fixed, thunderbird91 fixed)

RESOLVED FIXED
91 Branch
Tracking Status
thunderbird88 --- unaffected
thunderbird89 --- affected
thunderbird90 --- fixed
thunderbird91 --- fixed

People

(Reporter: aryx, Assigned: Paenglab)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

Latest Daily on Windows 8.1

The 'Add-ons and Themes' button's tooltip doesn't get shwon because of a wrong attribute name (tooltip should be tooltiptext):

https://searchfox.org/comm-central/rev/e5e75651c5fb70526ae298312d99bc37ffd1ad32/mail/locales/en-US/messenger/messenger.ftl#26-28

This will require a new entity name.

I also added a tooltip to the Quick Filter button which had none before.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9227716 - Flags: review?(alessandro)
Comment on attachment 9227716 [details] [diff] [review]
1716950-addons-and-themes-button.patch

Review of attachment 9227716 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.
Please, update the commit message to:
"Add missing tooltip to the addons and quick filter toolbar buttons"
Attachment #9227716 - Flags: review?(alessandro) → review+

Updated the commit message.

Attachment #9227716 - Attachment is obsolete: true
Attachment #9227724 - Flags: review+
Target Milestone: --- → 91 Branch

Comment on attachment 9227724 [details] [diff] [review]
1716950-addons-and-themes-button.patch

[Approval Request Comment]
User impact if declined: no tooltips on Add-ons and themes button and Quick Filter button
Testing completed (on c-c, etc.): soon on C-C
Risk to taking this patch (and alternatives if risky): low and it would be good if the strings are in beta to translate

Attachment #9227724 - Flags: approval-comm-beta?

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/c184b7398641
Add missing tooltip to the addons and quick filter toolbar buttons. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED

Comment on attachment 9227724 [details] [diff] [review]
1716950-addons-and-themes-button.patch

[Triage Comment]
Approved for beta

Attachment #9227724 - Flags: approval-comm-beta? → approval-comm-beta+

This bug has a target milestone of 91 so I'm setting the status-thunderbird91 flag to fixed.

You need to log in before you can comment on or make changes to this bug.