1716950 - 'Add-ons and Themes' button's tooltip is broken/not shown because of wrong attribute name

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Latest Daily on Windows 8.1

The 'Add-ons and Themes' button's tooltip doesn't get shwon because of a wrong attribute name (tooltip should be tooltiptext):

https://searchfox.org/comm-central/rev/e5e75651c5fb70526ae298312d99bc37ffd1ad32/mail/locales/en-US/messenger/messenger.ftl#26-28

This will require a new entity name.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1716950-addons-and-themes-button.patch

I also added a tooltip to the Quick Filter button which had none before.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9227716 [details] [diff] [review]
1716950-addons-and-themes-button.patch

Review of attachment 9227716 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.
Please, update the commit message to:
"Add missing tooltip to the addons and quick filter toolbar buttons"

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1716950-addons-and-themes-button.patch

Updated the commit message.

Comment 4

[Richard Marti (:Paenglab)]

Comment on attachment 9227724 [details] [diff] [review]
1716950-addons-and-themes-button.patch

[Approval Request Comment]
User impact if declined: no tooltips on Add-ons and themes button and Quick Filter button
Testing completed (on c-c, etc.): soon on C-C
Risk to taking this patch (and alternatives if risky): low and it would be good if the strings are in beta to translate

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c184b7398641
Add missing tooltip to the addons and quick filter toolbar buttons. r=aleca

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9227724 [details] [diff] [review]
1716950-addons-and-themes-button.patch

[Triage Comment]
Approved for beta

Comment 7

[Dave Miller [:justdave]]

Thunderbird 90.0b3
https://hg.mozilla.org/releases/comm-beta/rev/6d8d07d7532c

Comment 8

[Geoff Lankow (:darktrojan)]

This bug has a target milestone of 91 so I'm setting the status-thunderbird91 flag to fixed.