Radio buttons and checkboxes have bad contrast with Dracula GTK theme
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox91 | --- | verified |
People
(Reporter: poperigby, Assigned: emilio)
References
Details
Attachments
(4 files)
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:89.0) Gecko/20100101 Firefox/89.0
Steps to reproduce:
- Activate the Dracula GTK theme: https://draculatheme.com/gtk
- Go to any webpage that has no CSS styling on their radio buttons or checkboxes, like https://cbracco.github.io/html5-test-page
Actual results:
It's difficult to determine whether a radio button or checkbox is selected or not because the fill color is a light purple, and the background is white. This started happening after I updated to Firefox 89.
Expected results:
The radio button or checkbox should have contrasting colors that makes it easy to see if it's selected or not. It was like this pre-Firefox 89.
Comment 1•4 years ago
|
||
The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.
It might be related to a feature added in 89 called non-native theme.
If so, setting widget.non-native-theme.enabled
to false
in about:config and restarting firefox should make the color problem go away.
I filed a similar bug last week: https://bugzilla.mozilla.org/show_bug.cgi?id=1715521
Assignee | ||
Comment 4•4 years ago
|
||
Updated•4 years ago
|
Assignee | ||
Comment 5•4 years ago
|
||
This should be better in 90 with bug 1709647, but still not perfect. This theme does something slightly weird which is that it specifies a semi-transparent selected_bg_color
, but opaque selected_fg_color
:
/* base background color of selections */
@define-color theme_selected_bg_color rgba(189, 147, 249, 0.5);
/* text/foreground color of selections */
@define-color theme_selected_fg_color #f8f8f2;
Which is not something any other theme I've seen does, fwiw. Anyhow it seems blending that with the bg_color (we need an opaque color) makes sense here.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 6•4 years ago
|
||
While testing the above patch on a variety of gtk themes, I noticed that
selection colors were inconsistent (as in, from the old theme) when
switching gtk themes, and tracked that down to this call.
Since we only need to restore the theme when actually overridden, track
that instead.
Comment 9•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b873d938120e
https://hg.mozilla.org/mozilla-central/rev/72cb70926e87
Updated•4 years ago
|
Comment 10•4 years ago
|
||
I can't seem to be able to reproduce the issue on Firefox 89.0 on Ubuntu 18.04 x64. Can you please verify the fix on latest beta? You can find the build here.
Reporter | ||
Comment 11•4 years ago
|
||
I just tested on 91.0b7
and I'm still having the problem.
Assignee | ||
Comment 12•4 years ago
|
||
Can you post an screenshot of what you see? This is what I get, which looks like pretty decent contrast.
Reporter | ||
Comment 13•4 years ago
|
||
My apologies. It looks like I accidentally launched the wrong executable when testing. It actually is fixed on the latest beta. Thanks!
Comment 14•4 years ago
|
||
According to comment 12 and comment 13 I will mark this issue as verified fix. Thank you for checking this out.
Description
•