1717178 - Drop scriptable API which are used only by BlueGriffon

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement, P3)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

BlueGriffon refers mozilla-centrall at April 27 2017.
https://github.com/therealglazou/bluegriffon/blob/master/config/mozilla_central_revision.txt
https://hg.mozilla.org/mozilla-central/rev/c0d35b1c5ab5fa9bb2f5661aa0454a1ce31b50e0

And there is this issue:
https://github.com/therealglazou/bluegriffon/issues/99
but nobody replied to say "no".

Perhaps, we could delete scriptable APIs which is used only by BlueGriffon now.

The list of APIs:

• nsIEditor.doTransaction()
• nsIEditor.addEditorObserver()
• nsIHTMLAbsPosEditor.refreshGrabber()
• nsIHTMLEditor.getInlineProperty()
• nsIHTMLEditor.pasteNoFormatting()
• nsIHTMLEditor.setCaretAfterElement()
• nsIHTMLInlineTableEditor.refreshInlineTableEditingUI()
• nsIHTMLObjectResizer.refreshResizers()

Especially, the first 2 methods are too bad for mozilla-central.

glazou: Do you have any plan to keep updating BlueGriffon?

Comment 1

[Magnus Melin [:mkmelin]]

pasteNoFormatting() is used in Thunderbird as well, and quite handy so you don't get junk into the compose window.

Comment 2

[Magnus Melin [:mkmelin]]

Ah, I see, the actual function isn't called.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Magnus Melin [:mkmelin] from comment #2)

Ah, I see, the actual function isn't called.

Yes, using cmd_* is fine for now.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(And personally, I'd like to merge all interfaces rerated to nsIHTMLEditor in the future. It reduces the footprint and cuts QI cost in chrome script.)

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

No reply from BlueGriffon side. Let's get rid of them for now.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1717178 - part 1: Get rid of `nsIHTMLInlineTableEditor.refreshInlineTableEditingUI()` because of unused r=m_kato!

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1717178 - part 2: Get rid of `nsIHTMLAbsPosEditor.refreshGrabber()` because of unused r=m_kato!

Depends on D118797

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1717178 - part 3: Get rid of `nsIHTMLObjectResizer.refreshResizers()` because of unused r=m_kato!

Depends on D118798

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1717178 - part 4: Get rid of `nsIHTMLEditor.getInlineProperty()` because of unused r=m_kato!

Only test_bug1140105.html is its user, but it can be replaced with
getInlinePropertyWithAttrValue() since they do exactly same things:
https://searchfox.org/mozilla-central/rev/fc95c6ad297d9d257f05599d01741503f3f57326/editor/libeditor/HTMLStyleEditor.cpp#1685-1687,1719-1721

Depends on D118799

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1717178 - part 5: Get rid of `nsIHTMLEditor.pasteNoFormatting()` because of unused r=m_kato!

Depends on D118800

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1717178 - part 6: Get rid of `nsIHTMLEditor.setCaretAfterElement()` because of unused r=m_kato!

Depends on D118801

Comment 12

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1717178 - part 7: Get rid of `nsIEditor::AddEditorObserver()` and `nsIEditorObserver` interface because of unused r=m_kato!

Depends on D118802

Comment 13

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1717178 - part 8: Get rid of `nsIEditor.doTransaction()` because of unused r=m_kato!

Depends on D118803

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/302135e6f782
part 1: Get rid of `nsIHTMLInlineTableEditor.refreshInlineTableEditingUI()` because of unused r=m_kato
https://hg.mozilla.org/integration/autoland/rev/504a1b28770c
part 2: Get rid of `nsIHTMLAbsPosEditor.refreshGrabber()` because of unused r=m_kato
https://hg.mozilla.org/integration/autoland/rev/88fb5db3ed3b
part 3: Get rid of `nsIHTMLObjectResizer.refreshResizers()` because of unused r=m_kato
https://hg.mozilla.org/integration/autoland/rev/e7c97cafeec0
part 4: Get rid of `nsIHTMLEditor.getInlineProperty()` because of unused r=m_kato
https://hg.mozilla.org/integration/autoland/rev/91882492033a
part 5: Get rid of `nsIHTMLEditor.pasteNoFormatting()` because of unused r=m_kato
https://hg.mozilla.org/integration/autoland/rev/10c27ce19e42
part 6: Get rid of `nsIHTMLEditor.setCaretAfterElement()` because of unused r=m_kato
https://hg.mozilla.org/integration/autoland/rev/0cfa164a81a1
part 7: Get rid of `nsIEditor::AddEditorObserver()` and `nsIEditorObserver`  interface because of unused r=m_kato
https://hg.mozilla.org/integration/autoland/rev/2689403bd0d2
part 8: Get rid of `nsIEditor.doTransaction()` because of unused r=m_kato

Comment 15

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/302135e6f782
https://hg.mozilla.org/mozilla-central/rev/504a1b28770c
https://hg.mozilla.org/mozilla-central/rev/88fb5db3ed3b
https://hg.mozilla.org/mozilla-central/rev/e7c97cafeec0
https://hg.mozilla.org/mozilla-central/rev/91882492033a
https://hg.mozilla.org/mozilla-central/rev/10c27ce19e42
https://hg.mozilla.org/mozilla-central/rev/0cfa164a81a1
https://hg.mozilla.org/mozilla-central/rev/2689403bd0d2