1717290 - Add dedicated share button

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, enhancement)

Description

[kevonf]

User Agent: Mozilla/5.0 (iPhone; CPU iPhone OS 14_6 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) FxiOS/34.1 Mobile/15E148 Safari/605.1.15

Steps to reproduce:

I wanted to share a website with other people.

Actual results:

I couldn’t find the share menu because it wasn’t obvious where it should be, especially coming from Firefox for mobile.

Expected results:

There should have been a dedicated button to open the share button. Another option would have been to have a dedicated button for the current “right click on tab”-action. Because as it is right now, it is not very intuitive to find that menu and a button would help with the UX.

Comment 1

[Andre Klapper]

Which medium to use to "share with other people" exactly?

Comment 2

[Alin Ilea, Desktop Test Engineering]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:89.0) Gecko/20100101 Firefox/89.0

Hi,

Thank you for opening this enhancement. I will set this as New for visibility and waiting for the developers opinion about it.

Thanks for your report.

Comment 3

[Pelle Wessman]

And if no official such button gets added, is there an API that enables an addon to add it? Or could such an API be added?

Comment 4

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 1717290 - (part 1) Add a share tab button option to the toolbar. r=gijs

Comment 5

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 1717290 - (part 2) Testing for toolbar share-tab-button. r=gijs

Comment 6

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 1717290 - (part 3) Add a pref to toggle share button visibility and disable on linux. r=gijs

Comment 7

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 1717290 - (part 4) Record separate events for the share item selected when using the share button. r=gijs

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/81b9092ef914
https://hg.mozilla.org/integration/autoland/rev/7fcdead35e57
(part 1)  Add a share tab button option to the toolbar. r=Gijs,fluent-reviewers,desktop-theme-reviewers,bolsson,urlbar-reviewers,dao
https://github.com/mozilla-firefox/firefox/commit/7c01538e54d7
https://hg.mozilla.org/integration/autoland/rev/9b98e1866fff
(part 2) Testing for toolbar share-tab-button. r=Gijs
https://github.com/mozilla-firefox/firefox/commit/09854e601c3c
https://hg.mozilla.org/integration/autoland/rev/adf8f4d4d3de
(part 3) Add a pref to toggle share button visibility and disable on linux. r=Gijs
https://github.com/mozilla-firefox/firefox/commit/b6df612849f7
https://hg.mozilla.org/integration/autoland/rev/43b25e0614b5
(part 4) Record separate events for the share item selected when using the share button. r=Gijs

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/7fcdead35e57
https://hg.mozilla.org/mozilla-central/rev/9b98e1866fff
https://hg.mozilla.org/mozilla-central/rev/adf8f4d4d3de
https://hg.mozilla.org/mozilla-central/rev/43b25e0614b5

Comment 10

[Harshit Sohaney [:hsohaney]]

Release Note Request
[Why is this notable]: Adds a new customizable toolbar button to allow users to share the tab URL they are on.
[Affects Firefox for Android]: No
[Suggested wording]: You can now add a Share button to your toolbar from Customize Toolbar. It lets you easily share the URL of your current tab using your system’s sharing services.
[Links (documentation, blog post, etc)]: N/A

Comment 11

[Pascal Chevrel:pascalc]

(In reply to Harshit Sohaney [:hsohaney] from comment #10)

Release Note Request
[Why is this notable]: Adds a new customizable toolbar button to allow users to share the tab URL they are on.
[Affects Firefox for Android]: No
[Suggested wording]: You can now add a Share button to your toolbar from Customize Toolbar. It lets you easily share the URL of your current tab using your system’s sharing services.
[Links (documentation, blog post, etc)]: N/A

It seems that this is disabled for Linux, I will indicate that this is on Windows and macOS only in the note.

Comment 12

[Pascal Chevrel:pascalc]

Note added to 149 release notes with this wording:

You can now add a Share button to your toolbar from Customize Toolbar. It lets you easily share the addresss of your current tab using your Windows or macOS Operating system’s sharing services.

I am keeping the relnote-firefox? flag set until we include this note in our final 149 release notes, thanks.