1717354 - SeaMonkey comm-central l10n repacks fail

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Frank-Rainer Grahl (:frg)]

Packaging is now finally up to date again and building a localized installer should work. Unfortunately this is not the case. TB ran into this before and we need to port Bug 1644251
I didn't find the orginal Mozilla bug which regressed it.

0:13.36 Traceback (most recent call last):
0:13.36 File "c:\mozilla-build\python3\lib\runpy.py", line 193, in _run_module_as_main
0:13.36 "main", mod_spec)
0:13.36 File "c:\mozilla-build\python3\lib\runpy.py", line 85, in _run_code
0:13.36 exec(code, run_globals)
0:13.36 File "d:\seamonkey\comm-central\python\mozbuild\mozbuild\action\jar_maker.py", line 18, in <module>
0:13.36 sys.exit(log_build_task(main, sys.argv[1:]))
0:13.36 File "d:\seamonkey\comm-central\python\mozbuild\mozbuild\action\util.py", line 18, in log_build_task
0:13.36 return f(*args, **kwargs)
0:13.36 File "d:\seamonkey\comm-central\python\mozbuild\mozbuild\action\jar_maker.py", line 14, in main
0:13.36 return mozbuild.jar.main(args)
0:13.38 File "d:\seamonkey\comm-central\python\mozbuild\mozbuild\jar.py", line 649, in main
0:13.38 jm.makeJar(infile, options.d)
0:13.38 File "d:\seamonkey\comm-central\python\mozbuild\mozbuild\jar.py", line 374, in makeJar
0:13.38 self.processJarSection(info, jardir)
0:13.38 File "d:\seamonkey\comm-central\python\mozbuild\mozbuild\jar.py", line 425, in processJarSection
0:13.38 self._processEntryLine(e, outHelper, jf)
0:13.38 File "d:\seamonkey\comm-central\python\mozbuild\mozbuild\jar.py", line 502, in _processEntryLine
0:13.38 'File "{0}" not found in {1}'.format(src, ", ".join(src_base))
0:13.38 RuntimeError: File "brand.dtd" not found in d:/seabuild/c-c-cl/obj-x86_64-pc-mingw32/comm/suite/locales/merge-dir/de\comm/s
ite/branding/seamonkey
0:13.38 mozmake[4]: *** [d:/seamonkey/comm-central/config/rules.mk;867: misc] Error 1
0:13.38 mozmake[3]: *** [d:/seamonkey/comm-central/config/rules.mk;355: default] Error 2
0:13.39 mozmake[2]: *** [Makefile;119: l10n-de] Error 2

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1717354-repack-cc.patch

Tested and not found wanting.

Comment 2

[Ian Neal]

Comment on attachment 9228006 [details] [diff] [review]
1717354-repack-cc.patch

looks correct to me r=me

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b362a40c523e
Set correct l10n location for SeaMonkey branding files. r=IanN