1717545 - IRCv3.1: Implement SASL with PLAIN mechanism

Status: RESOLVED FIXED

(SeaMonkey :: Chat, enhancement)

Description

[Ian Neal]

Implement IRCv3.1 SASL with PLAIN mechanism CAP by cherry picking the relevant parts of the following commits from the Ambassador fork:
https://github.com/Ascrod/ambassador/commit/ae3ed5e8a0c9e5178c3a693d63c0e9e971848a34
https://github.com/Ascrod/ambassador/commit/076c7ba55e1e361803c3d980e684e12c9a601ede
https://github.com/Ascrod/ambassador/commit/f633a8c127a56d563a7b91f8e44ae095f27e0515
https://github.com/Ascrod/ambassador/commit/c330443eca93600c03e56cff03a4024e5aea5d13
https://github.com/Ascrod/ambassador/commit/c629abb20985e45b7c3fc62171306a16b0f353a1
https://github.com/Ascrod/ambassador/commit/d500368aaafc51c0278748bb63099634715a0ede
https://github.com/Ascrod/ambassador/commit/7537fde3524cae063308aae5df199cb914ec0627
https://github.com/Ascrod/ambassador/commit/446cc5621ed677d8cf7debaa2704bec9f157a2e3
https://github.com/Ascrod/ambassador/commit/087f37de8177efe4ef2e2ef86615bb7806e9cd60

Comment 1

[Ian Neal]

Attachment: 1717545-irc-sasl-CAP-2539.patch

[Triage Comment]
r/a=me

Comment 2

[Tony Mechelynck [:tonymec]]

Attachment: networks.json

I use a customized networks.json (see attachment) to connect preferably to European servers of libera, and by secure connection. I also use built-in SASL connection with SeaMonkey 2.53.9b1pre (Gianopoulos).

The fact that ChatZilla stores passwords in the password manager separately for each server and port within the network means that when the remote disconects me, and cZ tries to connect to the next server in the list, I get a password prompt hidden by the browser window, Ctrl-6 (Window→IRC Chat) stops working and I have to use the keyboard's "Windows" key to place all windows temporarily side-by-side, select the popup and answer it (or else, temporarily minimize the browser). By the time I have answered the popup, of course the remote has timed me out, so I get one more reconnect but at least with ChatZilla on top.

I don't have this problem with NickServ because I have a "ns identify mypassword" command (which doesn't get echoed in the ChatZilla window) as a network start-up command (in the "Lists" tab of the network preferences). (N.B. I'm the only user of this computer.) Having both SASL and NickServ identification is no problem because if the first one succeeds, the second one just says I'm already identified.

Comment 3

[Tony Mechelynck [:tonymec]]

P.S. To view the text of my new attachment, don't click "Details" — click the text of the attachment in comment #2.

Comment 4

[Tony Mechelynck [:tonymec]]

Sm 2.53.9b1pre 20210630210003 (and possibly yesterday's)

The popup now appears on top of everything (a mixed blessing), but since the "username" it stores in the Password Manager is not my services account name but my nickname, it makes a difference whether I'm starting SeaMonkey (nickname "tonymec") or reconnecting after a timeout (nickname "tonymec|away") so I cannot even expect that someday all servers/ports defined for libera in my networks.json will be "known" and that the prompts will disappear.

Comment 5

[Ian Neal]

Attachment: 1717545-irc-sasl-CAP-v1_1-25310.patch

Changes since last version:

• Store passwords against network URL and username rather than server URL and nickname.

Comment 6

[Ian Neal]

Attachment: 1717545-irc-sasl-CAP-v1_2-25310.patch

Changes since last patch:
Correct msg.sasl.password string to use username rather than nickname

Comment 7

[Ian Neal]

Attachment: 1717545-irc-sasl-CAP-v1_3-25310.patch

Also fix pref.sasl.plain.enabled.help

Comment 8

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9235249 [details] [diff] [review]
1717545-irc-sasl-CAP-v1_3-25310.patch

LGTM

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/36caa928508a
IRCv3.1: Implement SASL with PLAIN mechanism. r=IanN

Comment 10

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/111e3c625d40d81e9c93b45b9c471e2da8fc8bb8
IRCv3.1: Implement SASL with PLAIN mechanism. r=IanN a=IanN