1717638 - Remove extra menu separator in about logins

Status: VERIFIED FIXED

(Firefox :: about:logins, enhancement, P3)

Description

[Tim Giles [:tgiles]]

Attachment: Screenshot 2021-06-22 111040.png

UX has given a recommendation of removing the menu separator between options and help in bug 1651373 as part of the design refresh.

To help Mozilla out with this bug, here's the steps:

1. Comment here on the bug that you want to volunteer to help.
   This will tell others that you're working on the next steps.
2. Download and build the Firefox source code
   • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
   • You can also read the Developer Guide, which has answers to most development questions.
3. Start working on this bug.
   • You will need to remove the appropriate menu separator from the menu-button template in aboutLogins.html
   • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #lockwise-desktop channel on Element/Matrix most hours of most days.
4. Build your change with mach build and test your change with mach test toolkit/components/passwordmgr --headless. Also check your changes for adherence to our style guidelines by using mach lint.
5. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
   • How to Submit a Patch
   • This is when the bug will be assigned to you.
6. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland.
   • If there are changes requested, please read the "To update a submitted patch" section to ensure you don't accidentally create a duplicate revision!
   • Your code will soon be shipping to Firefox users worldwide!

Comment 1

[sauravsonu2310]

I want to work on this bug.

Comment 2

[Tim Giles [:tgiles]]

Hi there, I'll assign you the bug in that case. Please reach out on Element/Matrix if you have questions!

Comment 3

[Release mgmt bot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 4

[themel10rist]

I'm building my environment now and would like to pick this up as my first bug.

Comment 5

[themel10rist]

(In reply to themel10rist from comment #4)

I'm building my environment now and would like to pick this up as my first bug.

I have a patch ready for this.

Comment 6

[themel10rist]

Attachment: Bug 1717638 - Removed <hr> separator between Preferences and Help to fit current style guidelines. r=[e-mail]

Comment 7

[themel10rist]

:tgiles just a friendly bump on this. I submitted a patch a few days ago.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ced3f54c9a4
Removed <hr> separator between Preferences and Help to fit current style guidelines. r=[e-mail]

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/8ced3f54c9a4

Comment 10

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue using the latest Firefox Nightly 93.0a1 (Build ID: 20210830162701) on Windows 10 x64, Mac 11.5.1, Ubuntu 20.04 x64.

• The menu separator that was displayed between the "Options" and "Help" is removed.