Closed Bug 1717638 Opened 1 year ago Closed 10 months ago

Remove extra menu separator in about logins

Categories

(Firefox :: about:logins, enhancement, P3)

enhancement

Tracking

()

VERIFIED FIXED
93 Branch
Tracking Status
firefox93 --- verified

People

(Reporter: tgiles, Assigned: themel10rist, Mentored)

Details

(Keywords: good-first-bug)

Attachments

(2 files)

UX has given a recommendation of removing the menu separator between options and help in bug 1651373 as part of the design refresh.

To help Mozilla out with this bug, here's the steps:

  1. Comment here on the bug that you want to volunteer to help.
    This will tell others that you're working on the next steps.
  2. Download and build the Firefox source code
    • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
    • You can also read the Developer Guide, which has answers to most development questions.
  3. Start working on this bug.
  4. Build your change with mach build and test your change with mach test toolkit/components/passwordmgr --headless. Also check your changes for adherence to our style guidelines by using mach lint.
  5. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
  6. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland.
Mentor: tgiles
Severity: -- → N/A
Keywords: good-first-bug
Priority: -- → P3

I want to work on this bug.

Hi there, I'll assign you the bug in that case. Please reach out on Element/Matrix if you have questions!

Assignee: nobody → sauravsonu2310

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Assignee: sauravsonu2310 → nobody

I'm building my environment now and would like to pick this up as my first bug.

(In reply to themel10rist from comment #4)

I'm building my environment now and would like to pick this up as my first bug.

I have a patch ready for this.

Flags: needinfo?(tgiles)
Assignee: nobody → themel10rist
Status: NEW → ASSIGNED
Flags: needinfo?(tgiles)

:tgiles just a friendly bump on this. I submitted a patch a few days ago.

Pushed by tgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8ced3f54c9a4
Removed <hr> separator between Preferences and Help to fit current style guidelines. r=tgiles@mozilla.com
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch

I have verified this issue using the latest Firefox Nightly 93.0a1 (Build ID: 20210830162701) on Windows 10 x64, Mac 11.5.1, Ubuntu 20.04 x64.

  • The menu separator that was displayed between the "Options" and "Help" is removed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.