Remove fixed pixel font-sizes
Categories
(Thunderbird :: Theme, task)
Tracking
(thunderbird_esr91 wontfix, thunderbird_esr102 unaffected, thunderbird102 unaffected)
Tracking | Status | |
---|---|---|
thunderbird_esr91 | --- | wontfix |
thunderbird_esr102 | --- | unaffected |
thunderbird102 | --- | unaffected |
People
(Reporter: henry-x, Assigned: Paenglab)
References
(Blocks 1 open bug)
Details
Attachments
(6 files)
There are a handful of CSS font-size
values that use a fixed px
value: https://searchfox.org/comm-central/search?q=font-size%3A.*px&path=css&case=false®exp=true
Fixed font sizes will cause text to look different on different systems compared to the majority of non-fixed font. For example, I think on higher resolution displays, the fixed-font will appear relatively larger. It can also get in the way of accessibility.
It can also be a sign of a display hack, where we are relying on pixel perfect heights. We should be using different CSS in these cases anyway.
These should be removed in favour of smaller
, larger
, small
, large
, etc.
Comment 2•3 years ago
|
||
In addition to this, after the first patch from bug 1715364 lands, we will have the ability to add a font-size style to the body of the document allowing us to control the root font sizing of the entire interface.
We should make sure the font size applied to the root element makes every text element scale properly.
We shouldn't do everything at once but focus on each main tab, and then do the dialogs separately.
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Comment 3•3 years ago
|
||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 4•3 years ago
|
||
Assignee | ||
Comment 5•3 years ago
|
||
Depends on D129271
Updated•3 years ago
|
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/f888435d7106
Remove the fixed font size from menus. r=aleca
https://hg.mozilla.org/comm-central/rev/fd74e2470b10
Remove the fixed font size from arrow panels. r=aleca
https://hg.mozilla.org/comm-central/rev/ec47c6a24327
macOS: Remove the fixed font size from tabs and tree. r=aleca
Assignee | ||
Comment 7•3 years ago
|
||
Assignee | ||
Updated•3 years ago
|
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/75aec1da5976
Make the QFB and search boxes behave correctly with big fonts. r=aleca
Comment 9•3 years ago
|
||
Little regression caused by this change: https://searchfox.org/comm-central/rev/b566f045515206c94e15f299c6e07d246f82b011/mail/themes/shared/mail/messenger.css#669
The "Favorite" icon is actually a button which now has a min-height of 24px.
Reporter | ||
Comment 10•3 years ago
•
|
||
(In reply to Alessandro Castellani [:aleca] from comment #9)
Created attachment 9248982 [details]
Screenshot from 2021-11-02 21-01-08.pngLittle regression caused by this change: https://searchfox.org/comm-central/rev/b566f045515206c94e15f299c6e07d246f82b011/mail/themes/shared/mail/messenger.css#669
The "Favorite" icon is actually a button which now has a min-height of 24px.
This will probably effect other .plain-button
buttons. I made this class for wrapping clickable icons, but it is similarly used for other buttons that are meant to plainly wrap their content, and only apply button styling on focus and hovering.
It's used in the composition window (for the "Bcc", "Cc", remove row, and the #languageStatusButton
button in the bottom right), for the tab close button, and in for an Nntp message header https://searchfox.org/comm-central/search?q=plain-button&path=
Assignee | ||
Comment 11•3 years ago
|
||
Yes, I apply the fix on .button.plain-button
.
Assignee | ||
Comment 12•3 years ago
|
||
Assignee | ||
Updated•3 years ago
|
Comment 13•3 years ago
|
||
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/dc7808296f8f
Fix too tall buttons after adding min-height. r=aleca
Comment 14•2 years ago
|
||
Closing this to avoid having too many opened bugs with patches spanning across multiple versions.
We can continue this work and better organize things for 114 with dedicated meta bugs.
Updated•2 years ago
|
Description
•