Open Bug 1717811 Opened 4 years ago

Flip Pool._isDestroyed from Pool destroy

Categories

(DevTools :: Framework, task, P3)

Product:
DevTools
Component:
Framework
Type:
task

Tracking

(Not tracked)

People

(Reporter: jdescottes, Unassigned)

References

Details

Pool subclasses Front and Actor both implement a isDestroyed() method relying on similar mechanisms.

In Bug 1717580 we are moving part of the logic to drive isDestroyed in the parent class Pool. However, only Actor & Front currently flip the internal _isDestroyed flag, which means that isDestroyed() cannot be used on pure Pool.

Pure Pools are rarely used in DevTools : https://searchfox.org/mozilla-central/search?path=&q=new%20Pool( but it would still be nice to consistently allow isDestroyed() to be called for them.

Therefore we should also flip _isDestroyed in the Pool destroy. However, given that Front/Actor destroy sequences are critical and complex, it needs to be carefully tested.

You need to log in before you can comment on or make changes to this bug.