Closed Bug 1717897 Opened 4 years ago Closed 4 years ago

Remove NetworkHelper.nsIURL which leaks all generated nsIURL

Categories

(DevTools :: Netmonitor, defect, P3)

defect

Tracking

(firefox91 fixed)

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The gNSURLStore Map is never clear:
https://searchfox.org/mozilla-central/source/devtools/shared/webconsole/network-helper.js#99-100
So that NetworkHelper.nsIURL keeps leaking the generated nsIURL objects:
https://searchfox.org/mozilla-central/source/devtools/shared/webconsole/network-helper.js#891-902

This is only used from here:
https://searchfox.org/mozilla-central/source/devtools/shared/platform/cache-entry.js#95
which could probably avoid calling this method as request.URI is probably already a nsIURL object!

Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Severity: -- → S3
Priority: -- → P3
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/69b39bb22246 [devtools] Remove NetworkHelper.nsIURL which leaks all generated nsIURL r=Honza
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: