Closed Bug 1717991 Opened 7 months ago Closed 7 months ago

Code to add profiler markers should build even when MOZ_GECKO_PROFILER is not defined

Categories

(Core :: Gecko Profiler, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: florian, Assigned: florian)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Having the profiler headers declare all the marker related functions even when MOZ_GECKO_PROFILER is not defined would allow code that adds markers (including markers with custom schemas) to do so without ifdefs.

Severity: -- → N/A
Priority: -- → P3

These 2 patches resolve my build issue on Fedora 34 on ppc64le, thanks.

Pushed by fqueze@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8f7fc2f3bb31
Profiler headers should declare all the marker related functions even when MOZ_GECKO_PROFILER is not defined, r=gerald.
https://hg.mozilla.org/integration/autoland/rev/cd335ae78d20
Remove ifdefs around code that adds profiler markers with custom marker schemas, r=gerald.
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.