1717991 - Code to add profiler markers should build even when MOZ_GECKO_PROFILER is not defined

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement, P3)

Description

[Florian Quèze [:florian]]

Having the profiler headers declare all the marker related functions even when MOZ_GECKO_PROFILER is not defined would allow code that adds markers (including markers with custom schemas) to do so without ifdefs.

Comment 1

[Florian Quèze [:florian]]

Attachment: Bug 1717991 - Profiler headers should declare all the marker related functions even when MOZ_GECKO_PROFILER is not defined, r=gerald.

Comment 2

[Florian Quèze [:florian]]

Attachment: Bug 1717991 - Remove ifdefs around code that adds profiler markers with custom marker schemas, r=gerald.

Depends on D118679

Comment 3

[Dan Horák]

These 2 patches resolve my build issue on Fedora 34 on ppc64le, thanks.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f7fc2f3bb31
Profiler headers should declare all the marker related functions even when MOZ_GECKO_PROFILER is not defined, r=gerald.
https://hg.mozilla.org/integration/autoland/rev/cd335ae78d20
Remove ifdefs around code that adds profiler markers with custom marker schemas, r=gerald.

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/8f7fc2f3bb31
https://hg.mozilla.org/mozilla-central/rev/cd335ae78d20